Closed (fixed)
Project:
Panels
Version:
7.x-3.x-dev
Component:
In-Place Editor (IPE)
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Aug 2012 at 04:14 UTC
Updated:
16 Jun 2014 at 16:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
populist commentedHere is a patch that fixes the above problem. It basically does a "repainting" of the elements on init which forces Webkit (and I am going to guess IE) to readjust the widths and make these look right.
For bonus points, I also removed the logic to center the buttons in the IPE editor since they are no longer needed as per #1711302: Make "Add New Pane" an Icon with a Smaller Design
Comment #2
merlinofchaos commentedWhy would we even be doing that in javascript? Shouldn'tw e just set position: relative in the css?
Comment #3
populist commentedAs best I can tell, the problem here is that when the IPE is enabled it adds new visibile markup to the page which makes some of the width calculations (as per my screenshots) need to be recalculated. In order to do this, we need to add CSS *after* the markup is made visible which will force a repaint.
That being said, there might be a better CSS approach since repaints can be slow (http://www.stubbornella.org/content/2009/03/27/reflows-repaints-css-perf...) and all we really need is the IPE controls to be aligned correctly.
Comment #4
populist commentedI did some more research here and found a pure CSS approach here that involved setting a width: 100% on the parent container which fixes the problem (http://drupal.org/files/panopoly-draghandle-widths-after.png).
Comment #5
merlinofchaos commentedCommitted and pushed.