There is the word "inhalt" forced to lowercase. I guess it's "Inhalt" with an lcase() function, what is incorrect. This is a context sensitive bug and need to be made one translatable string like Add URL redirect to this content.
<a href="/admin/config/search/redirect/add?redirect=node/51&language=und&destination=node/51/edit">Add URL redirect to this inhalt</a>
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | Selection_058.png | 52.65 KB | pifagor |
| #20 | Selection_057.png | 129.34 KB | pifagor |
| #12 | 1712062-redirect-translatable-string-review--12.patch | 5.82 KB | tomsegarra |
| #7 | 1712062_redirect_Translatable+string+review2.patch | 6.39 KB | hass |
| #5 | 1712062_redirect_Translatable+string+review.patch | 5.88 KB | hass |
Comments
Comment #1
dave reidWe are not able to make it translatable in that context because the actual string is "Add URL redirect to this @entity" where @entity is a variable. We do not know all possible entity types.
Comment #2
hass commentedThan you need to leave the string as is, but forcing it lowercase is plain wrong in nearly every language except English.
Comment #3
dave reidPatches welcome then.
Comment #4
hass commentedThe best would be to remove the variable if we cannot translate it.
Comment #5
hass commentedAs discussed earlier I have synchronized the link to be generic. It is used 3 times in this modules so the Add URL redirect string is re-used.
Changing title and attaching a larger translatable review patch.
Comment #7
hass commentedFixed test
Comment #8
torotil commentedChanges in the strings look good. It still applies as is. Setting it to RTBC.
Comment #11
dave reidComment #12
tomsegarra commentedI've re-rolled the patch from #7 so that it applies to the latest HEAD. Since it was RTBC before, and a small typographical fix committed to the 7.x-1.x branch was all that broke it, I'm marking it as RTBC again.
Comment #13
pifagor commentedThe author of the patch should not display the status "Reviewed & tested by the community"
Comment #14
hass commentedAs it was only reroled and a small fix this is acceptable. Waiting 6 years is not acceptable.
Comment #15
pifagor commentedComment #18
pifagor commentedComment #19
hass commentedAuthored by me. Thanks for not giving credit.
Comment #20
pifagor commentedhttps://www.drupal.org/files/issues/2018-10-28/Selection_057.png - Sorry, I copied the comment, where you are not listed by the author.
I gave you credit - https://www.drupal.org/files/issues/2018-10-28/Selection_058.png
Comment #21
hass commentedSee "authored by". It is wrong.
Comment #22
pifagor commentedYou wrote that I did not give you credit. It's not true you got credit. Yes, you are not the author of the patch because I copied the text from the "Git command" column.
As far as I understand, the system put the author's patch "tomsegarra" because he last changed the patch.
Now I can not change anything, sorry. But dissatisfaction should be expressed not to me, but to the system drupal.org, because it makes the author patch the person who the last changed the patch.
Thank you for your contribution to the development of drupal.org
Comment #23
hass commentedI wrote the patch and tomsegarra only re-roled. Who do you think is the author of the code? tomsegarra is not.
In core we rollback and re-commit in such a case. No need for this action now, but please look more carefully into the case history before you commit patches in future.
Comment #24
pifagor commentedOf course. Thank you for your comments.