Regular expression used to create closing tag in function special_menu_items_render_menu_item() is wrong. Generated closing tag for i.e <span> is </s> instead of </span>. This causes bad behaviour of some modules like nice menus that can no longer display submenus. This may also fix problems reported by others like issues 1152500 or 1464774

Provided patch fixes regex and generates correct closing tag (</span> instead of </s>)

CommentFileSizeAuthor
fix_bad_closing_tag.patch924 bytesmarci003
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gagarine’s picture

gagarine CreditAttribution: gagarine commented

Thanks for the patch. I will fell more comfortable commit it if someone else can review that.

elBradford’s picture

elBradford CreditAttribution: elBradford commented

This patch fixes it for me, putting the ul of the child items as a sibling of the span instead of its child.

gagarine’s picture

gagarine CreditAttribution: gagarine commented
Status: Needs review » Fixed

committed thanks http://drupalcode.org/project/special_menu_items.git/commit/f2dba96

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

typo fix