Please add a views handler to display the send date in a view.

Even though I require it for a simplenews_statistics defined view, I believe that the handler belongs inside of simplenews core.

CommentFileSizeAuthor
#4 simplenews_statistics-add-send-date-statistics-and-views-integration-1660860-4.patch9.13 KBjjchinquist
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

That information is currently not stored? The only timestamp is in the simplenews_mail_spool table and that is temporary information that is removed again as configured.

jjchinquist’s picture

jjchinquist CreditAttribution: jjchinquist commented

Which is more logical for you Berdir? Store this information in the simplenews_newsletter table, or to store a "send_start" and "send_end" statistic in the module simplenews_statistics table simplenews_statistics?

jjchinquist’s picture

jjchinquist CreditAttribution: jjchinquist commented
Project: Simplenews » Simplenews Statistics

Hello Berdir. After looking at the databases again, I decided the more appropriate place for the values is in the simplenews_statistics module.

jjchinquist’s picture

jjchinquist CreditAttribution: jjchinquist commented
FileSize
simplenews_statistics-add-send-date-statistics-and-views-integration-1660860-4.patch9.13 KB

here the patch against the newest d7-1x version of simplenews_statistics.

Weseze, can you backport this update to the D6 version too?

Tested on 3 sites at work.

weseze’s picture

weseze CreditAttribution: weseze commented

The concept looks great! I will give it a go and backport to D6.

rmcom’s picture

rmcom CreditAttribution: rmcom commented

subscribing for D6

weseze’s picture

weseze CreditAttribution: weseze commented
Status: Active » Needs work

This patch will have to be rewritten. As of the latest dev version there is no simplenews_statistics table anymore since id didn't store any information that wasn't already available.

We could re-implement the table to store information like this however. And maybe we could store more information in the future in that table.

rmcom’s picture

rmcom CreditAttribution: rmcom commented

Has this been rolled into the D6 version? If not, I would love to help.

dieuwe’s picture

dieuwe
Location Auckland, NZ
CreditAttribution: dieuwe commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Issue summary: View changes
Status: Needs work » Patch (to be ported)

As far as I know this was never ported to D6.

dieuwe’s picture

dieuwe
Location Auckland, NZ
CreditAttribution: dieuwe commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Needs work

Sorry, I think I misunderstood some of the previous comments. This never even made it into the D7 version.

  • Commit 6b822e3 on 7.x-1.x by dieuwe: 
    Issues #1660860 and #2291485: Views integrations for send dates and...
dieuwe’s picture

dieuwe
Location Auckland, NZ
CreditAttribution: dieuwe commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs work » Patch (to be ported)

Okay, this feature is now in the D7 version.

I salvaged what I could from the patch and made some changes. The {simplenews_statistics} table has been reintroduced as an extension of the {simplenews_newsletter} table.

If anyone wishes to backport this to D6, patches are welcome.

  • dieuwe committed 6b822e3 on 7.x-2.x 
    Issues #1660860 and #2291485: Views integrations for send dates and...