When an image field is added to a product type, the user needs to manually click "upload" before clicking "save variation". Otherwise the image that was chosen is not saved.

It would would be more user friendly for the image to be saved when the user clicks "save variation".

http://imgur.com/d9tS0

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

philipbe’s picture

Issue summary: View changes

added image

bojanz’s picture

Title: Uploading variation image » File upload doesn't happen on inline entity form submit
Category: feature » bug
Status: Active » Fixed

Committed a fix.

philipbe’s picture

Awesome. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rapira101’s picture

Version: 7.x-1.x-dev » 7.x-1.1
Status: Closed (fixed) » Active

I had the same problem in the last branch of the module

NikaDevs’s picture

I've also found this bug in 7.x-1.1 - image will not uploaded if user simply selected image without clicking 'Upload' button.

vasike’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
1.06 KB

i can confirm this issue: no files uploaded without using 'Upload' button.

it seems that this issue happens because the file.js script from Drupal core file module doesn't get called.
here is a patch that adds this js file.

p.s. imho the solution should be an auto upload script, as without using 'Upload' button, there's no possibility to add/upload other files (multiple values) for referenced entity.
imagine 10 references with 10 files to upload each.
or maybe a compatibility (check) with an multiupload widget.

for example, here is an Commerce kickstart issue about this : #1714932-5: Improve usability of uploading files in attribute form.

vasike’s picture

Priority: Normal » Critical

it seems critical for Required File/Images fields.

Without using the Upload button, the referenced entity couldn't be saved and the file form element gets empty (Browse... again and again).

Sinan Erdem’s picture

I ended up using AutoUpload module (https://drupal.org/project/autoupload) and I recommend it.

bojanz’s picture

Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

added img link

nils.destoop’s picture

Issue summary: View changes
Status: Closed (fixed) » Active

I'm still having this issue. I tested 7.x-1.3 and dev. But both have the problem.
Uploads are only saved when clicking the upload button.

FiNeX’s picture

The same problem is reproducible using 7.x-1.5 version (tested with image and file fields)

FiNeX’s picture

After some test I've found a way to reproduce the bug. At first you've to enable jquery_update and set two different jquery versions as default and administrative pages. This will trigger the bug. After setting the same version on jquery update I've solved the problem.

DamienMcKenna’s picture

@FiNeX: Are you saying the problem is being caused by a jQuery conflict due to using jQuery_Update?

@zuuperman: Are you using jquery_update too?

FiNeX’s picture

@Damien: it looks so

artaphis’s picture

The problem is in old version of jquery.form.js. It works with 3.50, but doesn't with 2.69 (see https://www.drupal.org/node/2266303).

AaronBauman’s picture

So, does anyone have a fix?

I need jquery_update for many reasons.
Is there a particular version i should be using for admin?

joelpittet’s picture

I've been using jquery 1.7 fairly successfully for some time now.

AaronBauman’s picture

@joelpittet thanks, i'll give that a shot.
I've had serious issues with Views UI + jquery 1.7 in the past, so I may have to figure out how to manually override jquery_update on specific pages.

bojanz’s picture

Status: Active » Closed (fixed)

Okay, so there's no work left on this side. Thanks for letting us know.