Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The Get Started page contains a row of inline images that act as headers. These are then followed by the details for the four steps in four columns.
There are two problems with this implementation.
- Inline images are being used for presentation. This will make it difficult to restyle when we shift to a different layout. The arrow imagery isn't going to work when they are all vertically stacked.
- The HTML does not follow a correct document outline. The headers are not correctly sectioning the document. This will also screw us when we shift to a vertically stacked layout.
Comment | File | Size | Author |
---|---|---|---|
#16 | 1601856-get-started-bluecheese-16.patch | 4.26 KB | hackwater |
#14 | 1601856-get-started-bluecheese-14.patch | 4.29 KB | hackwater |
#14 | 1601856-get-started-drupalorg-14.patch | 1.47 KB | hackwater |
#13 | 1601856-13.patch | 5.76 KB | dead_arm |
Comments
Comment #1
Senpai CreditAttribution: Senpai commentedComment #2
Snugug CreditAttribution: Snugug commentedWhat do you mean by responsive? Have them scale? Sure you can
For loading different different images, that's a different story, but I've got some ideas. Let's discuss
Comment #2.0
Snugug CreditAttribution: Snugug commentedcode
Comment #3
Senpai CreditAttribution: Senpai commentedTagging for Sprint 4.
Comment #4
Senpai CreditAttribution: Senpai commentedTagging for Sprint 5.
Comment #5
Senpai CreditAttribution: Senpai commentedTagging for sprint 6.
Comment #6
LewisNymanDone http://theme-drupal_7.redesign.devdrupal.org/start
Comment #7
jhodgdonThis page is currently broken on both the test site I am using and the theming test site:
http://theme-drupal_7.redesign.devdrupal.org/start
http://new-drupal_7.redesign.devdrupal.org/start
I wasn't sure if you preferred a new issue or to reopen this one?
Comment #8
Senpai CreditAttribution: Senpai commentedAssigning to @mattfielding
Comment #9
MattFielding CreditAttribution: MattFielding commentedI have made some changes. The heading are now text rather than background images - and the numbers are now also content. I turned the background images into a single sprite as well.
I had to change a template file, so i'll submit a patch for that.
Comment #10
ruplSetting to active since we're missing a patch at the moment.
Comment #10.0
ruplSense + Clarity
Comment #11
hackwater CreditAttribution: hackwater commentedUpdating title to make it easier to find/associate the task with similar tasks.
Comment #12
hackwater CreditAttribution: hackwater commentedFix to Documentation page (removing documentation class from old layout partial) broke the Get Started page. See #1790784: Re-theme the documentation page for more details.
Comment #13
dead_armAttached patch is a fix for the 'Getting Started' layout which broke from a patch in [1790784]. This patch also fixes [1790784] as .documentation on the 'Documentation' landing will no longer pick up the 'Getting Started' layout styling.
By adding the .getting-started class to sites/all/modules/drupalorg/drupalorg/drupalorg-start.tpl.php, we also won't need to remove .documentation from the HTML in the body field of the 'Documentation' landing page.
Comment #14
hackwater CreditAttribution: hackwater commentedRe-rolling patch at #13 to separate drupalorg module changes from bluecheese changes; both Documentation page and Get Started page look good. Can anyone else chime in?
For ease of testing, the Get Started page:
Dev: http://theme-drupal_7.redesign.devdrupal.org/start
Live: http://drupal.org/start
Comment #15
ruplThe drupalorg module was updated with the patch in #14.
Unfortunately our d.o dev environment seems too far out of sync with the canonical bluecheese repo, so we'll have to wait for the new environment snapshot re-roll the bluecheese patch from #14 at that time. Thanks for the patches!
Comment #16
hackwater CreditAttribution: hackwater commentedRe-rolled patch in 14. Looks like the drupalorg patch for the template changes made it into the canonical tree, so we only need the CSS for the Bluecheese side of things.
Comment #17
hackwater CreditAttribution: hackwater commentedFor easy testing,
Dev: http://theme-drupal_7.redesign.devdrupal.org/start
Live: http://drupal.org/start
Comment #18
ruplCommitted to rev 66, wahoo!
Comment #19
tvn CreditAttribution: tvn commentedIs there a reason why the title of this page on D7 is "Get Started" instead of "Get Started with Drupal"?
Comment #20
hackwater CreditAttribution: hackwater commented@tvn: drupalorg.module defines all its menu items as having MENU_CALLBACK as their types. It seems that these type of menu items get their page titles from whatever is set in the DB, rather than from module code. If module code and DB menu item title match, then the pages appear to be OK. In the case of /start, there's a mismatch, and the page is built ignoring the menu item title in the module code. If we change the type to MENU_NORMAL_ITEM, it seems to work fine (D6 -> D7 API change in hook_menu, I believe)
Is my analysis correct? If so, should we change all MENU_CALLBACKs in drupalorg_menu to MENU_NORMAL_ITEMs?
Comment #21
tvn CreditAttribution: tvn commentedThere is another issue about this page in drupalorg queue #1645790: Re-theme the get started page, let's continue there since this one is fixed.
Comment #22.0
(not verified) CreditAttribution: commentedUpdated issue summary.