The Get Started page contains a row of inline images that act as headers. These are then followed by the details for the four steps in four columns.

There are two problems with this implementation.

  1. Inline images are being used for presentation. This will make it difficult to restyle when we shift to a different layout. The arrow imagery isn't going to work when they are all vertically stacked.
  2. The HTML does not follow a correct document outline. The headers are not correctly sectioning the document. This will also screw us when we shift to a vertically stacked layout.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Senpai’s picture

Assigned: Unassigned » LewisNyman
Issue tags: +drupal.org D7, +bluecheese, +sprint 3
Snugug’s picture

What do you mean by responsive? Have them scale? Sure you can

img {
  max-width: 100%;
  height: auto;
}

For loading different different images, that's a different story, but I've got some ideas. Let's discuss

Snugug’s picture

Issue summary: View changes

code

Senpai’s picture

Title: Convert 'Getting Started' steps to pure CSS » Convert the 'Getting Started' page's steps to pure CSS
Issue tags: +sprint 4

Tagging for Sprint 4.

Senpai’s picture

Issue tags: +sprint 5

Tagging for Sprint 5.

Senpai’s picture

Issue tags: +sprint 6

Tagging for sprint 6.

LewisNyman’s picture

jhodgdon’s picture

Status: Fixed » Needs work

This page is currently broken on both the test site I am using and the theming test site:
http://theme-drupal_7.redesign.devdrupal.org/start
http://new-drupal_7.redesign.devdrupal.org/start

I wasn't sure if you preferred a new issue or to reopen this one?

Senpai’s picture

Assigned: LewisNyman » MattFielding
Issue tags: +sprint 7

Assigning to @mattfielding

MattFielding’s picture

Status: Needs work » Needs review

I have made some changes. The heading are now text rather than background images - and the numbers are now also content. I turned the background images into a single sprite as well.

I had to change a template file, so i'll submit a patch for that.

rupl’s picture

Assigned: MattFielding » Unassigned
Status: Needs review » Active

Setting to active since we're missing a patch at the moment.

rupl’s picture

Issue summary: View changes

Sense + Clarity

hackwater’s picture

Title: Convert the 'Getting Started' page's steps to pure CSS » Re-theme the 'Get Started' page

Updating title to make it easier to find/associate the task with similar tasks.

hackwater’s picture

Fix to Documentation page (removing documentation class from old layout partial) broke the Get Started page. See #1790784: Re-theme the documentation page for more details.

dead_arm’s picture

FileSize
5.76 KB

Attached patch is a fix for the 'Getting Started' layout which broke from a patch in [1790784]. This patch also fixes [1790784] as .documentation on the 'Documentation' landing will no longer pick up the 'Getting Started' layout styling.

By adding the .getting-started class to sites/all/modules/drupalorg/drupalorg/drupalorg-start.tpl.php, we also won't need to remove .documentation from the HTML in the body field of the 'Documentation' landing page.

hackwater’s picture

Status: Active » Needs review
FileSize
1.47 KB
4.29 KB

Re-rolling patch at #13 to separate drupalorg module changes from bluecheese changes; both Documentation page and Get Started page look good. Can anyone else chime in?

For ease of testing, the Get Started page:
Dev: http://theme-drupal_7.redesign.devdrupal.org/start
Live: http://drupal.org/start

rupl’s picture

Status: Needs review » Needs work

The drupalorg module was updated with the patch in #14.

Unfortunately our d.o dev environment seems too far out of sync with the canonical bluecheese repo, so we'll have to wait for the new environment snapshot re-roll the bluecheese patch from #14 at that time. Thanks for the patches!

hackwater’s picture

Status: Needs work » Needs review
FileSize
4.26 KB

Re-rolled patch in 14. Looks like the drupalorg patch for the template changes made it into the canonical tree, so we only need the CSS for the Bluecheese side of things.

hackwater’s picture

Assigned: Unassigned » hackwater
rupl’s picture

Status: Needs review » Fixed

Committed to rev 66, wahoo!

tvn’s picture

Is there a reason why the title of this page on D7 is "Get Started" instead of "Get Started with Drupal"?

hackwater’s picture

Priority: Normal » Critical

@tvn: drupalorg.module defines all its menu items as having MENU_CALLBACK as their types. It seems that these type of menu items get their page titles from whatever is set in the DB, rather than from module code. If module code and DB menu item title match, then the pages appear to be OK. In the case of /start, there's a mismatch, and the page is built ignoring the menu item title in the module code. If we change the type to MENU_NORMAL_ITEM, it seems to work fine (D6 -> D7 API change in hook_menu, I believe)

Is my analysis correct? If so, should we change all MENU_CALLBACKs in drupalorg_menu to MENU_NORMAL_ITEMs?

tvn’s picture

There is another issue about this page in drupalorg queue #1645790: Re-theme the get started page, let's continue there since this one is fixed.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.