Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 1591928-language-tests-13.patch | 101.05 KB | aspilicious |
| #6 | 1591928-language-tests-6.patch | 101.04 KB | aspilicious |
| #3 | 1591928-language-tests-3.patch | 101.03 KB | aspilicious |
| #1 | 1591928-language-tests-1.patch | 101.03 KB | aspilicious |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedLet's try this
Comment #3
aspilicious CreditAttribution: aspilicious commentedHopefully this one is better
Comment #4
Gábor HojtsyAdding sprint tag for D8MI.
Comment #6
aspilicious CreditAttribution: aspilicious commentedThis one should pass
Comment #7
Gábor HojtsyI did not review the tests line by line, trust @aspilicious that only the required changes were done. Since we are doing other test cleanup too (eg. #1561004: Many tests still reference locale although they only need language module) and this is a pain to reroll, let's get this in sooner than later.
Comment #8
Tor Arne Thune CreditAttribution: Tor Arne Thune commented+1 to the RTBC, after having reviewed the patch.
Comment #9
RobLoachcore/modules/language/lib/Drupal/language/Tests/ is the correct location for all these. Namespaces correct, definitions are right. Looks good.
Comment #10
aspilicious CreditAttribution: aspilicious commented#6: 1591928-language-tests-6.patch queued for re-testing.
Comment #11
aspilicious CreditAttribution: aspilicious commented#1: 1591928-language-tests-1.patch queued for re-testing.
Comment #13
aspilicious CreditAttribution: aspilicious commented/me hates rerolls
Comment #14
catchCommitted/pushed to 8.x, thanks!
Comment #15
catchComment #16
Gábor HojtsySuperb, thanks all.