Implement UUID hooks so redirects can be deployed through deploy module.
This should be a separate module, since it alters the schema for adding the uuid field to redirect table.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | interdiff-1517348-9-13.txt | 2.43 KB | skwashd |
| #13 | redirect-1517348-uuid-13.patch | 4.84 KB | skwashd |
Comments
Comment #1
recidive commentedAttached patch introduces a media_uuid module for adding uuid field to redirect table and handling the conversion of rid to uuid and vice versa.
Comment #2
recidive commentedFixing a typos in key names.
Comment #3
skwashd commentedOverall this looks good and works well. One nitpick below.
Trailing whitespace
Comment #4
skwashd commentedThe attached version of the patch deals with quite a few issues with @recidive's patch.
Comment #5
skwashd commentedRerolled without the swap file in the patch.
Comment #6
jamesharv commentedIn the patch from #5,
redirect_uuid_entity_uuid_load()andredirect_uuid_entity_uuid_presave()are universalising the source property of the redirect, rather than the redirect property. I think this is incorrect. I've attached an updated patch with this correction.Comment #7
jamesharv commentedAfter running this patch for a bit I've realised that both the source and redirect values need to be universalised because it is quite possible to have a redirect where either the source or redirect are node urls (or both even). Here's a patch which universalises both.
Comment #8
jamesharv commentedAnother bug I've picked up with this is that the uuid of each redirect gets regenerated when you edit it. That's because the edit form doesn't post the uuid as a value, and only the form values are passed to
redirect_save()inredirect_edit_form_submit().Updated patch is attached with the hook_form_alter() implementation to add the uuid to the form's values.
Comment #9
jamesharv commentedThis is a slightly better version which uses
hook_form_FORM_ID_alter().Comment #10
indytechcook commentedPatch in number 9 works great
Comment #11
pere orgaComment #12
dave reidThese seem like things worthwhile to put back in redirect.module since these are not specific to UUID integration.
Comment #13
skwashd commentedRerolled with the change requested in #12.
Comment #14
skwashd commentedAfter 3 years of waiting I have created the UUID Extras project and committed a modified version of this patch there. Closing as WONTFIX.
Comment #15
dave reidWith no one to help peer review for over 9 months, I'm not sure what I should do. I don't use UUID or Deploy normally. If we're happy having it in a separate module, that seems best.