Closed (won't fix)
Project:
Open Graph meta tags
Version:
6.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Mar 2012 at 20:24 UTC
Updated:
3 Sep 2015 at 21:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
eelkeblokOK, so this is the closest thing to an existing issue I could find :) Yes, I foresee problems. I actually needed to solve the problem of the missing facebook-specific tags (app id and administrator ids) and I was already experimenting with nodewords. I too, however, did not like the way it handled the image meta tag, which this module does very nicely.
I installed both, but Facebook told me (by entering my page URL into https://developers.facebook.com/tools/debug) it failed validation due to double tags; both nodewords and opengraph_meta were including the tags (it *was* a long shot).
Long story short, as nodewords is somewhat of a standard for handling meta tags in D6, I thought it was a good idea to write a patch that makes this module play nice with nodewords. It basically turns off this module's own tag rendering (only when nodewords is present!) and instead uses nodewords' hooks to alter the tags it offers. The merging mechanism is fairly simple, it favours opengraph_meta's versions of the tags (when !empty) and overwrites nodewords' og tags. It will nog override nodewords_og's tags with empty values, though.
Comment #2
kruser commentedThanks, this patch worked well for me.
Comment #3
torotil commentedThe new 7.x-2.x version builds on metatag which by now seems the standard for managing metatags in drupal.
Comment #4
eelkeblokDoes that mean the 6.x version is not supported anymore? There is no Metatag module for Drupal 6, the Metatag for Drupal 6 is Nodewords.
Comment #5
torotil commentedYes. opengraph_meta wasn't supported for the last 3 years. It's (only?) maintainer has left the Drupal sphere since then. I took over the maintainership of the D7 version. I can't maintain the D6 version since I don't use Drupal 6. That leaves you with the following choice:
I'm only the messenger, because I closed all the D6 issues (thereby making the current state of this module explicit).
Comment #6
eelkeblokFair enough. Maybe you want to put the 6 version to unsupported, then. The fact that the D6 version is effectively unsuported is not very clear from the project page.
Comment #7
torotil commentedGood idea! I've marked it as unsupported.
Comment #8
grey_ commentedNo it's not a good idea. Now you are creating a situation where people are forced to upgrade or must deactivate the module, should they still have a site or two running on drupal 6 - which I do.
If there are no safety concerns - why not keep the version 6 module up. Pleeeease!
Comment #9
eelkeblokI'm not sure I understand what the problem is. If you keep your site in version control in its entirety, you have the module downloaded and there is no harm done. If you have a build process that re-downloads the module on every build (drush make?) you can still download what you need from the Git repository. This does clearly communicate that the D6 version is not supported to anyone that might consider starting to use this now (I know I have customers that keep asking for features on their D6 sites...)
Comment #10
AntiNSA commentedthanks for the patch! long live d6