Javascipt in collapse.js assume legend will be present, but since there's no title, no legend is outputted.

CommentFileSizeAuthor
#10 i1482636-6.patch1.86 KBkscheirer
#7 i1482636-7-d7.patch1.84 KBattiks
#6 i1482636-6.patch1.86 KBattiks
#3 i1482636-3.patch1.95 KBattiks
#1 i1482636-d7.patch1.93 KBattiks

Comments

attiks’s picture

attiks commented
StatusFileSize
new i1482636-d7.patch1.93 KB

Patch for D7

attiks’s picture

attiks commented
Status: Active » Needs review
attiks’s picture

attiks commented
Version: 7.x-dev » 8.x-dev
StatusFileSize
new i1482636-3.patch1.95 KB
droplet’s picture

droplet commented
Status: Needs review » Needs work
Issue tags: +Needs backport to D7 
+++ b/misc/collapse.jsundefined
@@ -74,28 +74,30 @@ Drupal.behaviors.collapse = {
-      var $legend = $('> legend .fieldset-legend', this);
+      if ($('> legend .fieldset-legend', this).length) {
+        var $legend = $('> legend .fieldset-legend', this);

Needs cached selector

droplet’s picture

droplet commented
Component: forms system » javascript

--

attiks’s picture

attiks commented
Component: javascript » forms system
Status: Needs work » Needs review
StatusFileSize
new i1482636-6.patch1.86 KB
attiks’s picture

attiks commented
StatusFileSize
new i1482636-7-d7.patch1.84 KB

patch for d7

Status: Needs review » Needs work

The last submitted patch, i1482636-7-d7.patch, failed testing.

attiks’s picture

attiks commented
Status: Needs work » Needs review

#6 needs review, ignore #7 for now

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
StatusFileSize
new i1482636-6.patch1.86 KB

Retesting against latest HEAD since it has been over a year.

The last submitted patch, i1482636-6.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

pameeela commented
Version: 8.9.x-dev » 7.x-dev
Issue summary: View changes
Issue tags: +Bug Smash Initiative

This was completely redone in D8 (starting with #1168246: Freedom For Fieldsets! Long Live The DETAILS.) so this isn't relevant anymore, bumping this back to 7.x.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.