This is a simple patch to speed up the packing/shipping process.

When a user goes to create a shipment or package that does not contain an existing one.
Rather than presenting an empty table with a link to create one, we redirect the user to the appropriate form.

CommentFileSizeAuthor
#10 faster_shipping.diff1.7 KBdavidarthur
#9 faster_shipping.diff1.7 KBdavidarthur
#6 faster_shipping.patch1.83 KBdavidarthur
#2 faster_shipping.patch1.56 KBdavidarthur
faster_shipping.patch1.56 KBdavidarthur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, faster_shipping.patch, failed testing.

davidarthur’s picture

davidarthur CreditAttribution: davidarthur commented
Status: Needs work » Needs review
FileSize
faster_shipping.patch1.56 KB

try again

Status: Needs review » Needs work

The last submitted patch, faster_shipping.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented

The patch failed to apply because it seems to be created with svn and not git, testbot requires git-style patches to work.

davidarthur’s picture

davidarthur CreditAttribution: davidarthur commented

cheers for spotting that, shame it doesn't give a more useful error message was just about to ask on irc...

well we use svn here so i'm gonna look for an svn to git patch converter

davidarthur’s picture

davidarthur CreditAttribution: davidarthur commented
Status: Needs work » Needs review
FileSize
faster_shipping.patch1.83 KB

Trying another patch

Status: Needs review » Needs work

The last submitted patch, faster_shipping.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented 
--- a/html/sites/all/modules/ubercart/shipping/uc_shipping/uc_shipping.admin.inc
+++ b/html/sites/all/modules/ubercart/shipping/uc_shipping/uc_shipping.admin.inc

should be just

--- a/shipping/uc_shipping/uc_shipping.admin.inc
+++ b/shipping/uc_shipping/uc_shipping.admin.inc
davidarthur’s picture

davidarthur CreditAttribution: davidarthur commented
FileSize
faster_shipping.diff1.7 KB

Last go today ;)

davidarthur’s picture

davidarthur CreditAttribution: davidarthur commented
Status: Needs work » Needs review
FileSize
faster_shipping.diff1.7 KB

:(

TR’s picture

TR CreditAttribution: TR commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
Assigned: davidarthur » Unassigned
Status: Needs review » Patch (to be ported)

Committed #10 after fixing coding standards.

Let's port this to 7.x-3.x as well.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Patch (to be ported) » Fixed

Ported and committed: http://drupalcode.org/project/ubercart.git/commitdiff/c046605

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.