the "type" parameter isn't checked for the global commit log and so arbitrary URLs can point to the log.

Another bug is that samething generates these URLs.

Google then crawls these which is bad for server load and content duplication.

Attahed patch fixes the first problem.

Comments

marvil07’s picture

Assigned: Unassigned » marvil07
marvil07’s picture

Assigned: marvil07 » Unassigned
Status: Active » Fixed
StatusFileSize
new1.72 KB

First, thanks for the patch!

I guess the original code the patch was written against was not really the current tip of 6.x-2.x, so I have rerolled it and applied it to that branch.

@killes: it would be great if you can explain a little more the second problem, so I can understand it(please re-open if you think is relevant to do it in this issue).

gerhard killesreiter’s picture

Google doesn't invent the URLs that it crawls, it finds them somewhere. So there must be a place in the code base that creates these (now) invalid URLs.

marvil07’s picture

Thanks for the explanation, now I understand. But to be able to solve it I will need your help telling me examples of those invalid URLs you are referring, so I can look for them on the code where they have been generated.

gerhard killesreiter’s picture

The invalid URLs look like this:

commitlog/commit/8af1ab44eb63c7edb144b9610e5d24027327c1dc

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

marvil07’s picture

  • Commit 9a1c21d on 6.x-2.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1388758 by killes@www.drop.org, marvil07: Fixed Multiple URLs...
  • Commit 8682524 on 6.x-2.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1388758 follow-up: Fixed Global commitlog feed is producing a...

  • Commit 9a1c21d on 6.x-2.x, repository-families by marvil07:
    Issue #1388758 by killes@www.drop.org, marvil07: Fixed Multiple URLs...
  • Commit 8682524 on 6.x-2.x, repository-families by marvil07:
    Issue #1388758 follow-up: Fixed Global commitlog feed is producing a...