otherwise it doesn't look good (imho).

diff --git a/content.module b/content.module
index 613abe6..e67394e 100644
--- a/content.module
+++ b/content.module
@@ -989,7 +989,7 @@ function theme_field(&$node, &$field, &$items, $teaser, $page) {
   if (!empty($items_output)) {
     $output .= '<div class="field field-type-'. strtr($field['type'], '_', '-') .' field-'. strtr($field['type'], '_', '-') .' field-'. strtr($field['field_name'], '_', '-') .'">';
     if ($label_display == 'above') {
-      $output .= '<div class="field-label">'. $label .':</div>';
+      $output .= '<div class="field-label">'. $label .': </div>';
     }
     $output .= '<div class="field-items">'. $items_output .'</div>';
     $output .= '</div>';

just a single blank after the colon and before the closing div and everything is fine ;-)

CommentFileSizeAuthor
#3 ie_label_space.patch526 bytesdeviantintegral
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

It's inside if ($label_display == 'above') {, so what's the difference ?

ray007’s picture

ups, wrong line.
I wanted to add the blank in line 982 in the inline case before the closing div, since I've seen some internet explorer problems not printing the space after the closing div before the content ...
Nobody else seen this?

deviantintegral’s picture

FileSize
526 bytes

I've been having this problem with inline labels on IE6/WinXP and IE7/Vista. The problem seems to be that IE is truncating the leading space in

tags. The fix is to replace the space with an  , which works in Opera/FireFox as well.

I've attached the simple patch and hope it can be included in the main distribution as I would imagine this affects anyone wanting inline labels.

--Andrew

deviantintegral’s picture

Category: feature » bug

Teaches me not to preview posts. If only the bug tracker kept track of uploads between previews.

What's missing is the &nbsp;.

I've also changed this category to 'bug report' as this seems like a pretty serious bug for anyone browsing with IE.

yched’s picture

Status: Needs review » Fixed

Fixed in 1.6 release (will be published later tonight)

Anonymous’s picture

Status: Fixed » Closed (fixed)