Javascript cleanup: Conflict w/ clientsidevalidation, compatibility w/ autocomplete & attachBehaviour, show button again

I wonder if there would be a solution for all ajax/js validated forms in general instead of just catering for clientside_validation module. Anyway, it would be very nice to play well with that module.

reopening this issue. hope you could assist on how to deactivate the hide submit if there are errors on the form like mandatory fields and stuff

Are you using the 7.x-1.x or 7.x-2.x version?

I wonder if there is a "hook" like concept for javascript so that other scripts could be polled for whether or not the form is ready to submit.

i am using the 7.x-2.x version.

OK, great to know. Now we just need to figure out how to take specific actions based on the client side validation somehow.

I wonder if client side validation has a mode to disable the button until all validation passes - then this module can only fire if the validation already passes.

Another idea that would solve this is #1847578: show submit button again after 5 or 10 seconds

Attached patch fixes this for the latest version of clientside_validation

Hi attiks, I just came across this same issue today, so I tried out your patch (which works nicely).

Only bug I found was that if I disabled the "Use fade effects?" setting when I choose to hide the submit button, then the button dissapears immediately when their are errors on clientside_validation. Not sure if you can replicate this?

You're right, should be fixed

Awesome thanks that new patch fixes the issue for me. Be great when both of these patches are in the current releases. Thanks again for your help.

Thanks for the work on this, attiks, and the review, ThomWilhelm.

I'm hesitant to commit this without also fixing #1842700: Improve compability with autocomplete and attachBehaviour improvements. Any chance you could review that patch and make sure both apply?

Edited to be the right issue

Whoops, #11 originally pointed to the wrong issue. I meant #1842700: Improve compability with autocomplete and attachBehaviour improvements.

New patch including elements from #1842700: Improve compability with autocomplete and attachBehaviour improvements and I added support for a timeout after which the buttons are reset, solving #1847578: show submit button again after 5 or 10 seconds.

Fixed - http://drupalcode.org/project/hide_submit.git/commit/cf3b1a9

Thanks, attiks and ThomWilhelm!

I'll probably roll a new release in about 2 weeks so that this can have some time to get tested in the 7.x-2.x-dev.

Updated title to reflect what this issue really fixed.

I am having this exact problem, only on a Drupal 6 site. I'm currently using the module version 6.x-1.12, which is the most recent available to D6. How can I solve this problem?

It doesnt work for me. When there are clientside validation errors, submit will be disabled, and after i fixed all errors the disabled attribute wont be removed.

modules:

hide submit button 7.x-2.0+0-dev
Clientside Validation 7.x-1.37
Jquery 1.7

Hi,

I am adding a new patch that solves hide submit and clientside validation conflict. In our case we use Workflow module, too. So, on node edit form we have two buttons: Save as draft(where we want to skip validation) and Save(where we want validation). We change the name attribute of the Save as draft button.

The issue can be reproduced in the following steps:
1. Enter Save button without entering all data/any data
2. Clientside validation module set errors and the form is not submitted
3. After that enter Save as draft

But here Drupal "think" that the triggered element is again the Save button.
So, i notice that hide_submit module is creating new hidden input with the same name=op as the last pressed button(Save). But on hideSubmitResetButtons function in the javascrit, this input and the settings.hide_submit_css class are not removed.
Hide submit button module create this hidden input with the same name attribute as the pressed button.

So, the patch removes the input and the class and Drupal get the right clicked button after failing validation and we can skip it in the draft case.

We are using the following module versions:
Workflow 7.x-2.x
Hide Submit Button 7.x-2.0
Clientside Validation 7.x-1.x
JQuery 1.7

I have the most recent versions of both hide_submit (7.x-2.0+1-dev) and clientside_validation (7.x-1.41) and this still doesn't work. Looking at the code (and I am far from a javascript expert), I can see that hide_submit.js has the call to hideSubmitResetButtons commented out in the clientsideValidationFormHasErrors binding. If I uncomment this, things work as I expected. Perhaps this was an oversight when checking in code?

Anyone else able to review #21?

#21 works for me. My use case is when Drupal commerce checkout form fails in form validation, either my custom js or clientside_validation will trigger a "clientsideValidationFormHasErrors" event to let hide_submit.js to reset submit button.

Module version: 7.x-2.0

#21 works for me. Here's an updated patch against the latest dev.

I also found that the following bugs when using hide_submit together with clientside_validation and form ajax:

hide_submit will create hidden element with the name and value of clicked button. But this hidden element will never be cleaned. So when client side validation fails, you can click submit button again and a duplicate hidden element will be created. This leads to multiple hidden elements.

It gets worse when you trigger an ajax event with non-button type element like select or checkbox for example later. As hidden element has not been cleaned, the hidden value of button will be accidently posted to remote server in an Ajax event which is not supposed to be. When button value is posted, Drupal will override original triggering element (say a radio element) in drupal_build_form()and use this button as new triggering element instead. And all validation and submit handlers of the original triggering element will never be executed.

I have attached a new patch and fix my problem. This patch is against the latest hide_submit version.

Add check to make sure hidden element will only be created once.

Patch #28 worked, I did some additional cleanup and some stricter checking.

#29 does not apply to 7.x-2.x-dev, however #28 does. It appears the patch in #29 was not created against 7.x-2.x-dev HEAD and would require a reroll.

Seems like @dmsmidt applied the wrong patch. The patch equals the interdiff.
I experienced JS errors with patch #29 when the submit button contains spaces and/or exclamation marks. I have added a new patch with double quotes wrapping the name and value of the button in the selector.

#32 patch applied cleanly and worked for me when I was experiencing an issue with this module conflicting with clientside_validation.