Problem/Motivation
We can convert /aggregator to a view. This gives more flexibility to the sitebuilder and is more consistent to what other modules are doing.
Remaining tasks
Figure out whether views should be a dependency to aggregator or not. If it shouldn't be then we need to add a fallback to the current patch in case views is not installed.
User interface changes
None
API changes
None
Beta phase evaluation
| Issue category | Task, as a part of #1823450: [Meta] Convert core listings to Views |
|---|---|
| Issue priority | Major, as a part of #1823450: [Meta] Convert core listings to Views |
| Prioritized changes | It reduces fragility by re-using views code and getting rid of custom listing code. It is also the last aggregator route to be converted to a view, which makes things more consistent |
| Disruption | There is no API change, since controllers are not considered public API. Only disruption would be for existing D8 sites running aggregator with views disabled (not many if any at all, since all other public aggregator's listing are converted to views already - see parent) |
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | drupal-aggregator-1337018-8.patch | 4.79 KB | geertvd |
| #8 | interdiff-1337018-6-8.txt | 1.25 KB | geertvd |
| #6 | drupal-aggregator-1337018-6.patch | 5.28 KB | geertvd |
| #3 | drupal-aggregator-1337018-4.patch | 5.64 KB | ParisLiakos |
| #3 | interdiff-1337018.txt | 3.12 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos commentedOr, you know; convert it to a view ;)
Comment #2
ParisLiakos commentedthis should be it
Comment #3
ParisLiakos commenteduh, this time with also removing the dead code
Comment #6
geertvd commentedReroll
Comment #8
geertvd commentedComment #9
geertvd commentedComment #10
dawehnerNice work!
Comment #13
jibranPasses on CI so back to RTBC.
Comment #14
alexpottDoes aggregator now depend on views?
Also the beta evaluation is not convincing. This is disruptive for site using aggregator but not views.
Comment #15
geertvd commentedI'm thinking it shouldn't be dependent on views, we might have to look into #1963544: Convert aggregator/rss to views also then since the rss feed is not available when views is disabled, I created a followup for that in #2553781: /aggregator/rss is not available when views is not installed.
Talked with alexpott via IRC on this and he think this might not be beta applicable so changing this to postponed right now.
Comment #16
ParisLiakos commentedNo, see #1864980: [meta] Figure out how to integrate Views into core
Also see #1823450: [Meta] Convert core listings to Views since this is a child of it which is major.
If those issues are not beta compatible the parent issue should be pushed to 8.1.x
Comment #17
ParisLiakos commentedComment #18
alexpottIs /aggregator a supplementary feature of the module? To me it seems a pretty central feature - so shouldn't it have a fallback?
Comment #19
ParisLiakos commentedComment #29
quietone commentedSurely this is fixed.
Yes work on this was in done in #1963544: Convert aggregator/rss to views and #2154781: Convert aggregator/sources and aggregator/opml to views. Closing as a duplicate.