Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
aggregator.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
7 Apr 2013 at 08:44 UTC
Updated:
29 Jul 2014 at 22:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ParisLiakos commentedpostponed on #1821844: Aggregator views integration
Comment #2
drupalninja99 commentedThis is good since we don't have a clean way (that I am aware of) to cleaning output XML in a page hook anyway.
Comment #3
ParisLiakos commentedintegration is in
Comment #4
ParisLiakos commentedLets keep OPML seperate for now, cause it needs an additional display plugin
Comment #5
dawehnerSo we accept that these settings are dropped?
This seems to be a valid information as well.
Comment #6
ParisLiakos commentedi closed #2004622: aggregator_test output includes drupal page content as duplicate, aggregator/rss is broken atm:) this fixes it
Comment #8
ParisLiakos commented#4: drupal-aggregator_rss_view-1955760-5.patch queued for re-testing.
Comment #9
pguillard commentedComment #10
pguillard commentedApparently something has changed at the same time. This is a new patch that should be ok.
Comment #11
pguillard commentedComment #12
lslinnet commentedWorking on a reroll of the patch:
Comment #13
lslinnet commentedThis should be the reroll, including a nice little interdiff
Comment #14
lslinnet commentedComment #15
Crell commentedI checked this out manually and it seems to be fine. The only comment I'd have is that for core views we should probably have meaningful display machine names. I don't know if we've been doing that in other Views conversions, though.
Can someone reroll with a useful machine name for the displays?
Comment #16
lslinnet commentedWill change the name to something meaning full as suggested.
Comment #17
lslinnet commentedHave updated the machine names so they now reflect what they are actually a list of (feed_items and feed_items_per_category)
Comment #18
Crell commentedYay!
Comment #19
tstoecklerI've seen among others @dawehner specifically request for the auto-generated display names (i.e. feed_1, etc.) to stay. I don't know why that is, and I also find meaningful names, well..., more meaningul!, but I give him the benefit of the doubt that this has a reason.
Comment #20
dawehnerTo be honest this is just personal preference (and the feeling that people overuse this feature), so I will not block that.
Comment #21
yesct commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #22
catchCommitted/pushed to 8.x, thanks!
Comment #23.0
(not verified) commentedIssue summary update
Comment #24
ParisLiakos commented