Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
title says all
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff-2154781.txt | 2.1 KB | ParisLiakos |
#14 | drupal-aggregator_sources_views-2154781-14.patch | 23.75 KB | ParisLiakos |
#11 | drupal-aggregator_sources_views-2154781-11.patch | 23.8 KB | ParisLiakos |
#11 | interdiff-2154781.txt | 1.85 KB | ParisLiakos |
#9 | drupal-aggregator_sources_views-2154781-9.patch | 22.42 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedThis was an awesome cleanup..got rid of 2 custom theme functions, and moved their custom logic to the EntityViewBuilders and views modes.
Also exposed feed's field UI..we need the same for items, but that can be done in another issue
Comment #2
ParisLiakos CreditAttribution: ParisLiakos commentedi need to add a test for #2114699: Regression: Aggregator item template expects an item to have an ftitle field but it can never have one so tagging accordingly
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedComment #5
ParisLiakos CreditAttribution: ParisLiakos commentedSo the plan goes like that:
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedi 've splitted most of the cleanup done here in a separate issue #2261425: Streamline aggregator's entities rendering with rest of core would be nice to get this in first
Comment #7
ParisLiakos CreditAttribution: ParisLiakos commentedprobably that easy after the issue above is in
Comment #9
ParisLiakos CreditAttribution: ParisLiakos commentedComment #10
dawehnerNote: We can actually force a given route name, if needed.
Are you sure this is actually still needed? I don't think so.
We fix them now, but shouldn't this be of type views.row.base or something like that? I guess we want to represent the views class hierarchy in the schema as well.
Comment #11
ParisLiakos CreditAttribution: ParisLiakos commentedWell it was the only way i could find to stop
Drupal\config\Tests\DefaultConfigTest
complain aboutdisplay.default.display_options.row.options
, if there is another way, happy to hear it!3. yes, good point
Also added some tests
Comment #13
dawehnerMeh, there was an issue adding
views.row.entity:*
which works for all of them. I will not block the issue for that.@ParisLiakos
Awesome work!!!!!!!!!!!!!!!!!
Comment #14
ParisLiakos CreditAttribution: ParisLiakos commentedThank you for the quick reviews!!
Yeah, that would be very nice! :) I tried to find it, but no success though:(
I put the new tests in a bad spot:P just some reordering and this should be back to green
Comment #15
dawehnerAwesome work!!
@Paris
It would be nice if you could write some change record.
Comment #16
ParisLiakos CreditAttribution: ParisLiakos commentedthank you!
i updated https://www.drupal.org/node/2084727 with the functions & paths removed
Comment #17
catchCommitted/pushed to 8.0.x, thanks!