Coder Review + Drupal coding standard [#1301646]

Created this issue for a general review of the module so it is confirm with all (or most of ) the drupal coding standards.
I'm currently running the modules (apachesolr and apachesolr_search) through coder and will report back with a patch that fixes general issues.

Comment	File	Size	Author
#3	1301646.patch	7.74 KB	Nick_vh
#3
#1	1301646-codereview.patch	15.09 KB	Nick_vh
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Nick_vh

he/him

Ghent

CreditAttribution: Nick_vh commented 6 October 2011 at 19:25

Status:

Active

» Needs review

File	Size
1301646-codereview.patch	15.09 KB

And as promised, the cleanup from the current dev. People could/should use this issue for further cleanups regarding code standards

Comment #2

scor CreditAttribution: scor commented 3 November 2011 at 02:36

Status:

Needs review

» Needs work

+++ b/apachesolr.module
@@ -2062,7 +2063,9 @@ function apachesolr_mlt_suggestions($settings, $id, $solr = NULL) {
+      $form[$key]['delete'] = array(
+          '#value' => l(t('delete'),
+          'admin/config/search/apachesolr/mlt/delete_block/' . $block['delta']['#value']));

should be only indented 2 chars, not 4.