Users who want to use Drush Make to build a distro which uses RobotsTxt will need to patch core to delete its robots.txt file. Any thoughts on providing such a patch with the module itself? In any case, attached is a patch that will be used in the distro I'm working on for the time being.

Comments

rickvug’s picture

StatusFileSize
new1.6 KB

Non git style patch of the same.

parsingphase’s picture

StatusFileSize
new1.67 KB

Rick's non-git patch, fixed.

rickvug’s picture

StatusFileSize
new1.71 KB

A line was added to robots.txt in the 7.8 release. A re-roll is attached.

hass’s picture

Category: task » feature

Several times I thought if drush allows me to setup a hook that does a file delete... I'm not sure what I should do with this patch.

ianthomas_uk’s picture

Is there not a better way of achieving this? My first thought would be a rewrite rule, but if that isn't possible for some reason then a core patch that provided a hook to make robots.txt replaceable (I appreciate that would mean turning robots.txt into a simple php script).

dnotes’s picture

Issue summary: View changes
StatusFileSize
new1.7 KB

New patch for documentation changes in 7.30.

Status: Needs review » Needs work

The last submitted patch, 6: 1260912-remove-robotstxt-7.30.patch, failed testing.

dnotes’s picture

Well, I guess I'm glad that a patch to strategically break part of core fails testing...

hass’s picture

Component: Code » Documentation
Category: Feature request » Support request
Status: Needs work » Fixed

As I think this is not really easy to maintain the core patch here I'm closing and leaving the remove patch creation to the maintainers of the Drupal Distributions. I's more flexible this way as we may have delays between core release and module releases. Additionally the required patch changes core and not this module it's a bit out of scope of this module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

_vid’s picture

Status: Closed (fixed) » Closed (won't fix)

Just updating ticket status to correctly reflect the outcome.

heathdutton’s picture

StatusFileSize
new1.63 KB

Updated for Drupal 7.36

We still haven't found a better way of doing this, while maintaining a proper make script build pattern... So patch it is.

gaëlg’s picture

StatusFileSize
new1.39 KB

For 8.0.2

gaëlg’s picture

StatusFileSize
new1.75 KB

Generated with:

version=8.0.5
cd ~/workspace/drupal
git reset --hard
git fetch origin
git checkout $version
rm robots.txt
git diff > 1260912-$version.patch
avpaderno’s picture

@#14 You should propose the patch for Drupal core. This is the project queue for a third-party module, which cannot change the files Drupal core provide.

gaëlg’s picture

I kept the "won't fix" status. The patch will never get committed, it's just here to be referenced by drush make files, as heathdutton mentioned. As this issue is only useful when robotstxt module is used, I guess it's easier to find it here.

nicola85’s picture

StatusFileSize
new2.36 KB

Updated for Drupal 7.50

marcelovani’s picture

I have a solution for D8 https://www.drupal.org/node/2832437