PHP Notice with statistics_exit() [#1253298]

Notice: Undefined index: HTTP_REFERER in statistics_exit() (line 83 of /DRUPAL7/modules/statistics/statistics.module).

I'm thinking that maybe FF6 isn't supplying referrer data. Just a guess, but my logs are getting filled up with this silly php notice.

Any reason not to do:

        'url' => (issset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '',

Comment	File	Size	Author
#1	1253298-statistics_exit_http_referer-1.patch	584 bytes	bfroehle
#1

Comments

bfroehle CreditAttribution: bfroehle commented 22 August 2011 at 18:14

File	Size
1253298-statistics_exit_http_referer-1.patch	584 bytes

Yes, we should use the isset($_SERVER['HTTP_REFERER']) ? ... pattern, just like in watchdog().

karschsp CreditAttribution: karschsp commented 22 August 2011 at 19:34

Status:

Needs review

» Reviewed & tested by the community

Patch applies to both 7.x and 8.x. RTBC.

Dries CreditAttribution: Dries commented 26 August 2011 at 09:25

Status:

Reviewed & tested by the community

» Fixed

Committed to 7.x and 8.x. Thanks.

he/him

English

CreditAttribution: mgifford commented 26 August 2011 at 10:19

Excellent. @bfroehle thanks for rolling up the patch. @Dries thanks & wish I was able to hang out in the code sprint after DrupalCon.

9 September 2011 at 10:21

Automatically closed -- issue fixed for 2 weeks with no activity.