Rules integration for Google Analytics goals tracking.

This is a pretty good idea, would be nice if someone could implement it.

Looks like a good solution. Where does the new variable go in relation to the existing analytics code generated by the module?

jOrd: you are NOT allowed to track user identifyable data (userid) with google analytics!!! I suggest you to read the google rules again. Code above have critical security issues. Don't use this code snippets.

#231451: Add hook to alter data before sending it to browser need to be done first.

Code injection is possible. There is a security issue.

Look into the api docs for drupal_to_js, drupal_json and drupal_add_js and as i know there is an api for session variables. Security issue is at $ga_item and implode. The linked issue should be fixed first and than we can look forward about the best way to get this stuff in.

subscribe

#231451: Add hook to alter data before sending it to browser

@j0rd how did you end up accomplishing goal tracking? I imagine there are about 50,000 others that would benefit from this feature request, or a how to. Thanks!

This is not a duplicate of #231451: Add hook to alter data before sending it to browser, which is about adding a new hook. This is about adding Rules integration - completely different. Mark it as won't fix if you like, but dont mark it as a duplicate as it clearly isn't.

Yes, but the integration of an external module that uses rules to enhance the tracker code need the hook, isn't it? :-) Therefore was my idea to push getting the hook in to allow other modules to enhance the tracker. I'm not sure what you may plan to track based on rules, but I'm open minded to new ideas and *patches* for the ga module.

I have since found GA Push which adds the ability to trigger custom GA Events to be fired based on Rules. It works very well and was exactly what I was looking for. Over and above triggering Events with Rules, I'm not what else it would be useful to have Rules do. But the fact that GA Push now provides this feature, I'd say this issue could possibly just be closed now.

There are unique urls. Login/logout are well known. Some others, too. Additionally many (most?) logged in users are not tracked if they are in admin sections.

GA Push is very simple. It provides a new Rules Action that is able to trigger a GA Event to be registered. So, you can hook as mank of these as you want into as many Rules Events as you like. Essentially, gives you all the power of Rules Actions and Conditions to trigger GA Events.

I hope these developer also blocks the use of personal data tokens.

I will review this module and may take over all this stuff.

Added link to google goal docs

subscribe

Here's a patch for the 7.x-1.x branch which provides a rule to create custom events and push them into Google Analytics. As mrfelton noted above, it is very simple.

Updating to needs review.

Thanks for the patch. That looks really easy.

However this one circumvent path exceptions, roles, DNT, maybe token placeholders with personal data and maybe other rules. And it's possible that there is no tracker and ga.js is missing on the page, but your events exits. This may cause JS errors. Never abbreviate names (e.g. "ga"), please. Running it in hook_init looks too early to me. I'm not sure if line 660 will not break as every value need double quotes and this may allow code injection. Line 669 and 670 has minor code style issues. Not sure, but is it correct that rules labels must not have strings in t()?

We also need 8.x-2.x and 7.x-2.x patches, too.

No problem. So we can easily fix the path exceptions, roles, and DNT by simply moving the hook_init code into googleanalytics_page_alter(). That's easy enough and it will fit better into the flow of things. Replacing json_encode with drupal_json_encode ought to take care of any security concerns. I checked on the hook_rules_action_info() page and t() appears to be used in the sample code on labels and groups.

I've implemented (to the best of my Rules knowledge) a form alter and validation that run the rules action form through the validation function in the admin inc file for each of the elements.

[duplicate comment]

1. +++ b/googleanalytics.module
   @@ -148,6 +148,22 @@ function googleanalytics_page_alter(&$page) {
   +        $events[] = drupal_json_encode(array('_trackEvent', $event['action'], $event['label'], $event['value']));
   

   I believe this is not secure and allow code injection. I believe every single param need to be encoded by it's own. Not tested. Try to write some values with double and single quotes...

2. +++ b/googleanalytics.module
   @@ -630,3 +649,64 @@ function _googleanalytics_visibility_header($account) {
   +/**
   + * implements hook_form_alter()
   + *
   + * @param $form ¶
   + * @param $form_state ¶
   + * @param string $form_id ¶
   + */
   +function googleanalytics_form_alter(&$form, &$form_state, $form_id) {
   +  // If this form is adding or editing a rules element that matches our rule plugin ¶
   +  // name, add a validator that checks for PII.
   +  if (($form_id == 'rules_ui_edit_element' || $form_id == 'rules_ui_add_element') ¶
   +    && $form_state['rules_element']->getPluginName() == "action googleanalytics_send_event") {
   +    array_unshift($form['#validate'], 'googleanalytics_validate_rules_pii');
   +  }
   +}
   +
   +/**
   + * Validate the form to ensure that no elements are being used that include personally
   + * identifiable information.
   + *
   + * @param $form ¶
   + * @param $form_state ¶
   + */
   +function googleanalytics_validate_rules_pii($form, &$form_state) {
   +  module_load_include('inc', 'googleanalytics', 'googleanalytics.admin');
   +
   +  foreach (element_children($form['parameter']) as $key => $param) {
   +    $data = &$form['parameter'][$param];
   +
   +    // Grab the actual element.
   +    $is_select = !empty($data['settings'][$param . ':select']);
   +    $element = $is_select ? $data['settings'][$param . ':select'] : $data['settings'][$param];
   +    $element['#old_value'] = $element['#value'];
   +
   +    if ($is_select) {
   +      // If it is a select, we "tokenize" it.
   +      $element['#value'] = '[' . $element['#value'] . ']';
   +    }
   +    // Do the heavy lifting.
   +    googleanalytics_token_element_validate($element, $form_state);
   +
   +    // Undo anything we did.
   +    $element['#value'] = $element['#old_value'];
   +  }
   +}
   

   Huh? Are you not able to reuse the custom variables element validation?

3. +++ b/googleanalytics.module
   @@ -630,3 +649,64 @@ function _googleanalytics_visibility_header($account) {
   + * @param $form ¶
   

   There are trailing spaces in this and many other lines.

1. Read the docs. drupal_json_encode is safe as it encodes '<', '>', "'", and '"' (even in arrays). You can run this drush command to verify: drush php-eval "echo drupal_json_encode(array('a', \"b\", 3, '\"4\"', \"'5'\"));"
2. No. If you are editing the rule using a token "data selector" which allows you to select a token using auto-complete, the token value is submitted without its enclosing brackets []. Therefore, we have to add those brackets before doing the actual validation since that's what the existing function looks for.
3. I ran the code formatter on the entire module but it introduced many other changes aside from my code. You might want to run it on the entire module.

1. where are you sourounding every value with quotes that are not json encoded? I do not see this and they are required as I know.
3. i'm not aware of any code style bugs in the module. I guess your code formater does something wrong. Coder has a lot of bugs.

1. All of the values that are user-entered are passing through drupal_json_encode (inside of the array), which is going to protect from any sort of injection. Can you give me an example or be a little bit about what exactly your issue is with the implementation?
3. Trailing white-spaces from the patch have been removed.

Fixed a problem with some errors when creating certain kinds of rule elements.

Is there any news about that patch, I would love to see google analytics providing some helpful rules actions to manage goals.

As already mentioned https://www.drupal.org/project/ga_push as the requested features. I think we can therefor close this issue.

Well, but I'd like to integrate this feature.

I will stop maintenance of 1.x soon and there is also a duplicate for 2.x. Please join there.

Has someone in here and idea how to enable Rules module? See #2306551: Module completly broken, cannot enable.