Perhaps Admin menu can adopt the same fix used in #520368: Admin toolbar breaks sticky table headers
Also see #428844: Use JS to adjust layout (a fix for all margin/absolute/background problems)
and #801526: Use misc/displace.js to position admin_menu

CommentFileSizeAuthor
#6 admin_menu-sticky_headers_issue-1210844-somewhat_fixed.png30.88 KBklonos
#5 admin_menu.tableheader.5.patch1.39 KBsun
#1 admin_menu-sticky_headers-1210844-1.patch893 bytespillarsdotnet

Comments

pillarsdotnet’s picture

pillarsdotnet commented
Status: Active » Needs review
StatusFileSize
new admin_menu-sticky_headers-1210844-1.patch893 bytes

The following patch works but it's obviously not the right way to do it.

modstore’s picture

modstore commented

Will a fix for this be included in dev, or is applying this patch the only option for now?

pillarsdotnet’s picture

pillarsdotnet commented

The patch in #1 will *not* be included in dev. As I said, it is not the right way to do it.

Anonymous’s picture

Anonymous (not verified) commented

I checked how the drupal core toolbar was handling this and make it work using this javascript (as part of my theme scripts)

Drupal.adminmenu = {
    height: function() {
	  var height = $('#admin-menu').outerHeight();
	  // In IE, Shadow filter adds some extra height, so we need to remove it from
	  // the returned height.
	  if ($('#admin-menu').css('filter').match(/DXImageTransform\.Microsoft\.Shadow/)) {
		height -= $('#toolbar').get(0).filters.item("DXImageTransform.Microsoft.Shadow").strength;
	  }
	  return height;
    }
};
Drupal.settings.tableHeaderOffset = 'Drupal.adminmenu.height';
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new admin_menu.tableheader.5.patch1.39 KB

Thanks for reporting, reviewing, and testing! Committed to all 3.x branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Status: Fixed » Active
StatusFileSize
new admin_menu-sticky_headers_issue-1210844-somewhat_fixed.png30.88 KB

...improved situation perhaps, but not entirely fixed :/

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

...this happens for me in my permissions pages where my roles also happen to be wrapping in two lines. I just checked the blocks admin page and the sticky header is still completely hidden there (only a few headers and they don't wrap).

PS: ...using latest 7.x-3.0-rc1+32-dev (2012-Mar-02).

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed

Apparently, you're using the toolbar style, which increases the total height of the menu.

That's a separate issue.

And it might make sense to wait for the outcome of #742184: Shortcut.module integration, but perhaps not. ;)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

That's a separate issue.

Is there an actual issue filed for that or perhaps you meant "That's a separate matter" and that I should file an issue myself? Also, I don't see how this relates to #742184: Shortcut.module integration (?)

dimitriseng’s picture

dimitriseng commented

Hi, just to note that I am also having this issue when using the Toolbar style and I think that it would be good to get that to work properly also as a lot of people are probably using the Toolbar style, thank you.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

Yeah, I searched but didn't find any separate issue filed for this. Please let us know if it will be handled here of if we should file a separate issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

I've opened a separate issue: #1489542: Admin menu covers sticky headers when the Toolbar style is used.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Issue summary: View changes

Added links to older issues.