Incremental UX improvements to Field UI

Looking at the code and the screenshots I think this is a major +1.
I hate those long pages.

I think this makes a lot of sense, if yched confirms the code it can be moved to RTBC quickly. You might want to add "no actions" as tabs as guideline to http://drupal.org/node/1089894 .

It would also be good if we could shrink the size of help text down to 1 row - 2 max. Brief, succinct statements will go a long way towards helping people use Drupal.

Another thumbs up for this. I'll gladly rewrite UI strings in a follow-up (other! ;-) issue.

The proposed changes are fine by me. Note that the "Global settings" section should supposedly be on its way out in D8 - was too late to do it in D7.

Changed 2 nitpicky stuff :
- 'required' / 'description' form elements : instead of just changing weights, swapped the code blocks so that the code flow follows the form flow.
- for visual code consistency, expanded the $form['actions']['submit'] definition as well.

That's only code formatting (interdiff attached), so pushing to RTBC.

For a proper clean-up, shouldn't we get rid of the delete page callback too?

@@ -138,7 +138,7 @@ function field_ui_menu() {
             'title' => 'Delete',
             'page callback' => 'drupal_get_form',
             'page arguments' => array('field_ui_field_delete_form', $field_position),
-            'type' => MENU_LOCAL_TASK,
+            'type' => MENU_VISIBLE_IN_BREADCRUMB,
             'weight' => 10,
             'file' => 'field_ui.admin.inc',

Dries, I think this does the job by changing the menu item.

29 days to next Drupal core point release.

+++ b/modules/field_ui/field_ui.admin.inc
@@ -1865,11 +1868,32 @@ function field_ui_field_edit_form($form, &$form_state, $instance) {
 /**
+ * Handle the 'Delete' button on the field instance edit form.
+ */
+function field_ui_field_edit_form_delete_submit($form, &$form_state) {
+  $destination = array();
+  if (isset($_GET['destination'])) {
+    $destination = drupal_get_destination();
+    unset($_GET['destination']);
+  }
+  $instance = $form['#instance'];
+  $form_state['redirect'] = array('admin/structure/types/manage/' . $instance['bundle'] . '/fields/' . $instance['field_name'] . '/delete', array('query' => $destination));
+}
+
+/**

Just a side node to say that as a future clean-up, it would be nice to refactor this and node_form_delete_submit() in a FormAPI delete helper.

I've posted #1236780: generalize node_form_delete_submit() to a FormAPI helper -- which will need rerolling when this patch gets in.

Committed to 8.x. Thanks.

It would also be good if we could shrink the size of help text down to 1 row - 2 max. Brief, succinct statements will go a long way towards helping people use Drupal.

What about "Let's Make All Help Text Fields 2 Rows Max Initiative"?