Add style links to field image formatter

I'd love to have this feature too. Instead of appending the image styles to the 'Link image to'-select box I would prefer having a new dropdown containing all image styles appear underneath the existing one when the 'File' option is chosen.

#1: 1186872-field_formatter_add_style_link.patch queued for re-testing.

+++ b/modules/image/image.field.inc
@@ -473,8 +476,11 @@ function image_field_formatter_settings_summary($field, $instance, $view_mode) {
+  foreach ($image_styles as $style) {
+    $link_types[$style] = t('Linked to !style file', array('!style' => $style));
+  }

What if there's a style called 'content' or 'file'? I think we need to name space the new link types:

$link_types['image_style_' . $style] = ...

Can you reroll agains the new codebase?

Tagging

Reroll

Patch again doesn't apply anymore. Another reroll needed…

1. +++ b/core/modules/image/lib/Drupal/image/Plugin/Field/FieldFormatter/ImageFormatter.php
   @@ -75,8 +78,11 @@ public function settingsSummary() {
   +      $link_types[$name] = t('Linked to !style file', array('!style' => $style));
   

   s/file/image/?

2. +++ b/core/modules/image/lib/Drupal/image/Plugin/Field/FieldFormatter/ImageFormatter.php
   @@ -91,26 +97,36 @@ public function settingsSummary() {
   -
   ...
   +
   

   Please don't change whitespace unless it's necessary.

3. +++ b/core/modules/image/lib/Drupal/image/Plugin/Field/FieldFormatter/ImageFormatter.php
   @@ -91,26 +97,36 @@ public function settingsSummary() {
   +    elseif ($image_link_setting) {
   

   This might as well say elseif (TRUE)… a comparison is missing? :)

4. +++ b/core/modules/image/lib/Drupal/image/Plugin/Field/FieldFormatter/ImageFormatter.php
   @@ -41,8 +41,11 @@ public function settingsForm(array $form, array &$form_state) {
   -      'file' => t('File'),
   +      'file' => t('File source'),
   

   Shouldn't this be "Original image"?

5. +++ b/core/modules/image/lib/Drupal/image/Plugin/Field/FieldFormatter/ImageFormatter.php
   @@ -41,8 +41,11 @@ public function settingsForm(array $form, array &$form_state) {
   +      $link_types[$name] = t('File !style', array('!style' => $style));
   

   This would result in strings like:

   • "File thumbnail"
   • "File medium"

   … neither of those really make sense, do they?

   Wouldn't something like !style image style be better? That'd result in:

   • "Thumbnail image style"
   • "Medium image style"

I will try to perform my first reroll.

I rerolled the patch from #8 and applied the changes mentioned in #9. The changes between the rerolled patch and my changes for #9 are visible in interdiff-comment-9-after-reroll.txt. I hope that helps reviewing that patch.

Patch #11 works against an updated code base and all improvements from #9 are included.

+++ b/core/modules/image/lib/Drupal/image/Plugin/Field/FieldFormatter/ImageFormatter.php
@@ -97,8 +97,8 @@ public function settingsSummary() {
     $elements = array();
-    $image_link_setting = $this->getSetting('image_link');
 
+    $image_link_setting = $this->getSetting('image_link');
     // Check if the formatter involves a link.

Why make this unnecessary whitespace change?

Plus, test coverage is still missing.

I'll try to reroll the patch first and fix the whitespace issue.

The rerolled patch that applies to the current HEAD. Now i try to investigate to write a test.

My whitespace remarks in #13 didn't make any sense. So the reroll looks great, this now just needs tests! Thanks :)

fixing the amsterdam sprint tag to amsterdam2014

Yep, thank you. Still working on the tests.

I added some testcode to verify the correct functionality. Thereby i found a bug my original implementation. image_style_load does not exist any more, so i replaced it with entity_load('image_style', ...); See the attached interdiff.

Reviewing this issue.

Patch #21 needs a re-roll...

The rerolled patch applies to current HEAD. Made some updates to pass all tests (ImageFieldDisplayTest).

Rerolled the patch as per the latest D8 Release.

Changing the status to Needs Review.

Fix.

As a new feature, this has to go in 8.2.x now.

I'm not sure this is important enough to be in core, is this really a common use case? Could also be a contrib module that provides this functionality.

@claudiu.cristea I have appliyed Patch but not working giving error sharing screenshot ....

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.