UI: Flickering fieldsets

Can reproduce on FF2/Ubuntu. Example case: http://drupal.org/search/node (try expanding the advanced search fieldset). Some have been unable to notice maybe too fast hardware or maybe something else. Also, if root cause is from outside collapse.js' code, then http://drupal.org/node/109208 (widgeditor loading twice per textarea) might be related too.

This has been popping up at various times with jQuery. It seems like a jQuery or Firefox bug.

It started happening after Drupal RC2. Before that fieldsets expanded very smoothly and there were no so issues with widgeditor even. Heine pointed http://drupal.org/node/110935 Maybe this be however related to it?

I've replicated the issue... it happens for me in either FF or IE, and I noticed it just happens when the expanding fieldset needs to scroll the window. I know Gurpartap said it does it for him all the time, but I'm wondering if it only in these cases for anyone else, too.

(Example: go to search/node and expand the advanced search fieldset once. Then collapse it again. Then without moving the window expand it again. For me, it doesn't flicker the second time, and I'm wondering if the window scrolling code is related to the problem?)

Just to confirm: I just checked out DRUPAL-5-RC-1; as Gurpartap indicated; no problems there.

Next I applied the patch from #1 in Upgrade jQuery to 1.0.4. This introduced the behaviour described above.

(in Opera 9.10)

Subscribing (confirmed in FF/OS X).

with drupal5 released when upgrading to jquery 1.1.1 the fieldsets will not collapse after uncollapsing them (FF1.5.x and Safari).

Removing the fieldset.animating test from collapse.js will fix this.

Can it be that this was introduced as a workaround?

Changing the title. It's not just collapsible fieldset title, but also happening with widgeditor, and maybe other related stuff too? Also, sometimes fieldset titles go missing, which can be recovered as soon as you click any link on that page. Is that related to this too?

Pointed this issue to John Resig and he verified the problem with fieldsets (viz with fieldsets only and not widgeditor, really unsure about that case yet). He told that it'll be fixed in the upcoming jquery release, i.e. 1.1.2. In that case, should we upgrade jquery in drupal5.x to 1.1.x? or move a patch into it, fixing the flickering fieldsets problem?

D5 ships with jQuery 1.0.x. 1.1.x is not backwards compatible with 1.0.x unless we either a) check over all our code, b) include a backwards compatible library. Both of these things sound pretty big for what should only be minor and meagre updates to the 5.x branch. Though I want it, I think the chances of it happening are pretty slim.

Brandon Aaron sent the attached zipped file(remove .txt extension and extract, sorry!) which includes the fixed jQuery (includes full jquery.js, lite, packed and minified). Tested and works great. Would be very nice of, if someone can build a patch against it :)

The patch fixes this issue and Two text area "body" fields with widgEditor for me.

Ops, just this issue, widgEditor works randomly :-(

Not critical. But this breaks completely in konqueror (3.5). the collapsed field will open, once open it jumps to closed state again. and stays there. Effectively breaking the niterface completely.

@berkes, is that behaviour before or after the patch? or both?

From IRC:

berkes: webchick: before. I don't have a 5 testbed yet.

Someone have Konqueror who can do a before/after comparison?

I am investigating this. But... weirdness: the "won't" stay uncollapsed as described only happens on Drupal.org. I am closing in on the CSS: it seems the order of the CSS matters.

In any case: the patch fixes the flickering for konqueror too. Konq has the same flickering issue on Garland (and other core themes) without the patch.

Where is this for 6?

this is a jQuery bug, which is fixed since version 1.1.
I assume we are going to ship drupal 6 with the latest jQuery build available from jquery.com, right?

If so, perhaps we can close this issue?

Not sure if anyone is trying to get our jQuery code up with the newest jQuery..

As far as I can tell, no, there's no push to get jQuery 1.1 in either with rewrite to our core .js's to bring it to the new API or by including the compat library. There's a jjeff jQuery update module which does this, but 1.1 should be in core, IMO :(

Hmm. i am surprised we would ship with old jquery. i'd like to know if thats a deliberate decision or what.

I believe the reason we don't have jQuery 1.1 in core yet is merely that no one has done it, nor has anyone really advocated for it.

The jQuery 1.1 issue is http://drupal.org/node/105574

This should no longer be an issue unless we don't get jQuery 1.1 into core for D6.

Gurpartap now has a patch in progress for jQuery 1.1 at http://drupal.org/node/146462

Marking as duplicate as the issue for jQuery update to 1.1.3 fixes this..