Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Fidelix’s picture

Indeed.

Babalu’s picture

subscribing

Babalu’s picture

subscribing

Babalu’s picture

subscribing

Babalu’s picture

subscribing

Babalu’s picture

ups so many

geek-merlin’s picture

Title: D7 port? » D7 port of Hide-submit-button
Optalgin’s picture

I'll find the time to port it soon
I already did some work but it is conflicting with the D7 overlay display
I will issue an alpha release until this conflict is solved

If anyone is interested in helping this port, you are more then welcome!

geek-merlin’s picture

@Optalgin - you wanna commit your efforts? i'm interested in that and als i dont have plenty of spar time i might squash a bog or another.
;-)

guillaumev’s picture

FileSize
142.28 KB

Hi,

Here is a first shot. This version obviously does not provide all of the features of version 6.x, but it will allow you to change the image of the loader and hide the submit button (therefore providing the most basic functionality for Drupal 7).

It is not tested and definitely not ready for production, but it's a start...

bryancasler’s picture

subscribe

milos.kroulik’s picture

subscribe

CarbonPig’s picture

subscribe

basicmagic.net’s picture

subscribe

Fidelix’s picture

@basicmagic.net

Stop subscribing, start following:
http://drupal.org/node/1306444

mgifford’s picture

@guillaumev Thanks. It's really useful to have this as a beginning point.

Usually a maintainer like @Optalgin would want to see a patch rather than a tarball. It's also important to know where you started from. Generally it's recommended to start from Git - http://drupal.org/node/337844/git-instructions

Did you run the code through http://drupal.org/project/coder

Let us know and hopefully the community can help make it easier for the maintainer to move this project along to a full D7 release.

malc_b’s picture

Bug?

I get error messages undefined hide_submit_toggle_random lines 371, 403 in hide_submit_admin.inc. I don't think this feature is in the port as it seems to be commented out (line 295) so the form validate function, line 367 has nothing to do and needs to be disabled or removed.

Likewise the function below, hide_submit_admin_settings_submit needs the Randomize elseif and else disabled.

Bug 2.

I also find that the enter key triggers the display of "please wait..." and graphic irrespective of the setting on the admin page. And this doesn't seem to have submitted the form, but I would not expect pressing enter in the title field to submit anyway. At this time the please wait and graphic appears just underneath an image icon/link and not at the bottom of form where submit button is. This content type has an image field on it. Enter seems to trigger submit ok on content without image fields. Perhaps a solution is to stop enter working like that (which seems wrong to me as the user might want to CR in the text field and just has the wrong focus).

Update: http://drupal.org/node/212423 , http://drupal.org/node/634616 , http://drupal.org/node/631334 discuss this. Enter to submit the form is required for accessibility and a whole other can of worms. Hence it looks like there are 2 bugs. The hide submit image goes to the wrong place and replaces the remove button of image field. And the enter key isn't always submitting the form anyway. I suspect the latter action is some work around as from the 3 link the problem is complex.

Optalgin’s picture

Thank you @guillaumev for your contribution!

Added a new branch 7.x-1.x-dev
This is not a full working release but it's a good start and a base code for patches
You are more then welcome to submit patches/fixes if you have
I hope I'll have more time to make it stable soon

greggles’s picture

Status: Active » Needs work
FileSize
8.58 KB
greggles’s picture

I took this a bit further by following coder's advice and fixing other little things as I noticed them. Attached is my patch and a "no whitespace" version made with "git diff -w". Even with these changes it still needs some more work to become functional.

There's a pretty critical problem with the administration screen right now that it doesn't save. Instead you get "An illegal choice has been detected. Please contact the site administrator."

The current module feels overly complex to me. I see no reason why it should have a feature to allow uploading the image or the "random" replacement image built into the module itself. I wonder if there should be a new 7.x branch that is much lighter weight and allows everything to be overridden by theme functions as appropriate. That would make it much easier to maintain the module (i.e. and upgrade it to new versions of core).

greggles’s picture

I found that the block_submit module is pretty much exactly what I want. I don't see why the projects are separate and both lacking in active maintenance. (Note that the 7.x version needs a small patch to work super duper well #1813382: Finish 7.x port, make stable release).

I would like to become maintainer of both (even if just temporarily) so that I could move the block_submit code into a 7.x-2.x branch of this module. That way people who want to upgrade their site will easily find a new thing that roughly matches their expectations even if it's not perfect. Optalgin granted me commit rights to this module, but not explicit permission to create a new branch that follows a different strategy. If someone wants to move this module forward keeping the current feature set then now would be a great time to step forward to do that. This is the process: http://drupal.org/node/251466

mgifford’s picture

That would be great!

Elijah Lynn’s picture

Version: 6.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Reviewed & tested by the community

This should be marked as closed right? I see a 7.x branch now.

greggles’s picture

Yep - thanks!

Elijah Lynn’s picture

Status: Reviewed & tested by the community » Closed (fixed)