I just committed Features integration to the Drupal 6 version: http://drupal.org/cvs?commit=501020

We need to port it to Drupal 7. Patch is attached.

CommentFileSizeAuthor
#5 features-integration-nodeformcols-1063342-5.patch1.4 KBscottrigby
#3 nodeformcols_features-1063342_3.patch1.04 KBlangworthy
#2 nodeformcols_features_2.patch1.04 KBvoxpelli
#1 nodeformcols_features_2.patch1.03 KBvoxpelli
nodeformcols_features.patch582 bytesvoxpelli

Comments

voxpelli’s picture

voxpelli commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Needs review
StatusFileSize
new nodeformcols_features_2.patch1.03 KB

The implementation wasn't a 100% correct - here's a follow up patch to the above - both need to be applied.

voxpelli’s picture

voxpelli commented
StatusFileSize
new nodeformcols_features_2.patch1.04 KB

There was a typo in the previous patch - fixed in this one.

langworthy’s picture

langworthy commented
StatusFileSize
new nodeformcols_features-1063342_3.patch1.04 KB

Patch from #2 rerolled using --no-prefix flag with git diff

chromix’s picture

chromix commented

I'm getting the following error:

WD php: Parameter 3 to nodeformcols_features_pipe_node_alter() expected to be a reference, value given [error]
in drupal/acquia-drupal-1.2.36/includes/common.inc on line 2892.
WD php: file_put_contents(sites/all/modules/features/my_feature/my_feature.views_default.inc): [error]
failed to open stream: Permission denied in drush/includes/drush.inc on line 1164.
Created module: my_feature in sites/all/modules/features/my_feature [ok]
Parameter 3 to nodeformcols_features_pipe_node_alter() expected to be a reference, value given in [warning]
includes/common.inc on line 2892.
file_put_contents(sites/all/modules/features/my_feature/my_feature.views_default.inc): failed to [warning]
open stream: Permission denied in drush/includes/drush.inc on line 1164.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
StatusFileSize
new features-integration-nodeformcols-1063342-5.patch1.4 KB

Why change $data to $export['features']['node']?

Also this patch drops $module_name (re #792472: Implement node type -> strongarm pipe for Features).

Maybe i'm missing why that needs to be there though?

voxpelli’s picture

voxpelli commented

@scottrigby: See #1078478: Multiple features and strongarm conflicts regarding $data - can you check your change against that patch as well?

asherry’s picture

asherry commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

I'm going to close this as I'm no longer supporting this project, and it doesn't seem like the work on this was finished. Feel free to re-open if anybody is still actively working on this.