Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Over at #1045902: "No core project specified." error from drush make we're having an issue because there's no core version specified. However, it goes through all of my existing projects checking for them before it spits out the error. Not really any point in doing that. :)
Comment | File | Size | Author |
---|---|---|---|
#4 | smarter_nocore.patch | 4.19 KB | dmitrig01 |
Comments
Comment #1
dmitrig01 CreditAttribution: dmitrig01 commentedThe issue here is that to determine whether or not there is a core project specified, it has to check to make sure each project isn't a core project -- it uses the Update XML from drupal.org to determine the type of project (module, theme, core, profile, etc), so it has to look at the Update XML of every one of them to make sure that they aren't core.
Comment #2
webchickOh, interesting. So it can't just check the array of projects to see if it's 'drupal' or 'type = core'?
Then this is probably "by design" :)
Comment #3
dmitrig01 CreditAttribution: dmitrig01 commentedYeah, the basic idea here is someone could set up a project.module or feature server to serve an alternate core under an alternative name (I have no idea why no one has done this for pressflow, but if it was done from pressflow, including pressflow would be as simple as
projects[pressflow][location] = http://somewhere
).It could probably be optimized by knowing that if it's coming from drupal.org, it's only "core" if it's called "drupal". However, if there is stuff coming from other update XML sources it'd need to be checked first (we don't want there to be more than one core).
Comment #4
dmitrig01 CreditAttribution: dmitrig01 commentedDoes this work?
Comment #5
dmitrig01 CreditAttribution: dmitrig01 commentedLet's call this good and I can deal with bug reports later
Comment #6
burningdog CreditAttribution: burningdog commentedThis may be related/the same issue: the latest drush_make stable (6.x-2.0) won't run if I'm using pressflow instead of drupal. A simple makefile (like the following) fails with "No core project specified."
I tried to apply the patch to 6.x-2.0, but note this issue is for 6.x-2.x-dev - which was last released on October 4, 2009. Is this patch for the 3.x-dev branch?
Comment #7
markwk CreditAttribution: markwk commentedI was having the same problem with Mac OSX and Drush_make as described by Roger Saner. I applied that patch to drush_make and it seems to work fine now downloading pressflow as core.
Comment #8
dan3h CreditAttribution: dan3h commentedWe are having exactly the same problem as in #6. Fails with "No core project specified" for a simple pressflow make file.
It was drush 3.3, so tried upgrading to 4.2, but still same problem. Drush_make is version 2.0.
But on another server we have, it was building pressflow make files no problem. So I copied that setup, and now both servers are working.
What is working: Drush 3.1, and drush_make 2.0-beta9. Also, now drush_make is installed as a subdir of the drush dir (in /opt/drush/drush_make), rather than in ~/.drush/drush_make where it was before. I have no idea (and doubt) if this is part of the problem, but it is one other difference in the setup that I can think of.
Just glad it is working for the time being.
Comment #9
glennpratt CreditAttribution: glennpratt commentedLooks like this breaks Pressflow, sorry I didn't have more time to review. Backing this patch out of 2.0 makes it work for me.
Comment #10
davidtrainer CreditAttribution: davidtrainer commentedSame issue here. Reversed the patch in #4 and Drush make happily built my pressflow platform.
Comment #11
dmitrig01 CreditAttribution: dmitrig01 commentedfixed in 2.x-dev
Comment #13
rerooting CreditAttribution: rerooting commentedAny plans for this fix to show up in soon-to-come 2.3 or 3.0? Just wondering....