Over at #1045902: "No core project specified." error from drush make we're having an issue because there's no core version specified. However, it goes through all of my existing projects checking for them before it spits out the error. Not really any point in doing that. :)

CommentFileSizeAuthor
#4 smarter_nocore.patch4.19 KBdmitrig01
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dmitrig01’s picture

The issue here is that to determine whether or not there is a core project specified, it has to check to make sure each project isn't a core project -- it uses the Update XML from drupal.org to determine the type of project (module, theme, core, profile, etc), so it has to look at the Update XML of every one of them to make sure that they aren't core.

webchick’s picture

Oh, interesting. So it can't just check the array of projects to see if it's 'drupal' or 'type = core'?
Then this is probably "by design" :)

dmitrig01’s picture

Yeah, the basic idea here is someone could set up a project.module or feature server to serve an alternate core under an alternative name (I have no idea why no one has done this for pressflow, but if it was done from pressflow, including pressflow would be as simple as projects[pressflow][location] = http://somewhere).

It could probably be optimized by knowing that if it's coming from drupal.org, it's only "core" if it's called "drupal". However, if there is stuff coming from other update XML sources it'd need to be checked first (we don't want there to be more than one core).

dmitrig01’s picture

Status: Active » Needs review
FileSize
4.19 KB

Does this work?

dmitrig01’s picture

Status: Needs review » Fixed

Let's call this good and I can deal with bug reports later

burningdog’s picture

This may be related/the same issue: the latest drush_make stable (6.x-2.0) won't run if I'm using pressflow instead of drupal. A simple makefile (like the following) fails with "No core project specified."

api = 2
core = 6.x

projects[pressflow][type] = "core"
projects[pressflow][download][type] = "get"
projects[pressflow][download][url] = "http://files.pressflow.org/pressflow-6-current.tar.gz"

I tried to apply the patch to 6.x-2.0, but note this issue is for 6.x-2.x-dev - which was last released on October 4, 2009. Is this patch for the 3.x-dev branch?

markwk’s picture

I was having the same problem with Mac OSX and Drush_make as described by Roger Saner. I applied that patch to drush_make and it seems to work fine now downloading pressflow as core.

dan3h’s picture

We are having exactly the same problem as in #6. Fails with "No core project specified" for a simple pressflow make file.

It was drush 3.3, so tried upgrading to 4.2, but still same problem. Drush_make is version 2.0.

But on another server we have, it was building pressflow make files no problem. So I copied that setup, and now both servers are working.

What is working: Drush 3.1, and drush_make 2.0-beta9. Also, now drush_make is installed as a subdir of the drush dir (in /opt/drush/drush_make), rather than in ~/.drush/drush_make where it was before. I have no idea (and doubt) if this is part of the problem, but it is one other difference in the setup that I can think of.

Just glad it is working for the time being.

glennpratt’s picture

Status: Fixed » Needs work

Looks like this breaks Pressflow, sorry I didn't have more time to review. Backing this patch out of 2.0 makes it work for me.

$ git revert 782594fc5fcf249aa1823149a1ce589afeef9dfc
Finished one revert.
[detached HEAD d748578] Revert "#1045906 by dmitrig01: be smarter about detecting a nocore situation"
 1 files changed, 22 insertions(+), 41 deletions(-)
davidtrainer’s picture

Same issue here. Reversed the patch in #4 and Drush make happily built my pressflow platform.

dmitrig01’s picture

Status: Needs work » Fixed

fixed in 2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rerooting’s picture

Any plans for this fix to show up in soon-to-come 2.3 or 3.0? Just wondering....