When importing files (batch or not) the log messages contain no reference to the actual file name, which, in case of a batch, makes things hard to debug in case of a problem. This patch intends to add that information in the log.

CommentFileSizeAuthor
#2 1045818-feeds_log_filename.patch823 bytesmakara
#1 feeds_log_filename.patch930 bytesmakara
feeds_log_filename.patch904 byteshunvreus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

makara’s picture

makara CreditAttribution: makara commented
Status: Active » Needs review
FileSize
feeds_log_filename.patch930 bytes

There's a mistake in the patch - wrong file name for a batch import.

Here's an updated patch, built on GIT branch 7.x-2.x.

makara’s picture

makara CreditAttribution: makara commented
FileSize
1045818-feeds_log_filename.patch823 bytes

The patch in #1 only works for Git (or patch -p1).

Here's a more general patch.

twistor’s picture

twistor CreditAttribution: twistor commented
Status: Needs review » Needs work

Wouldn't this mean that FeedsHTTPFetcher also needs to log what url its downloading, etc?

dianacastillo’s picture

dianacastillo CreditAttribution: dianacastillo as a volunteer commented
Issue summary: View changes

is this incorporated into 7.x-2.0-beta1 ?

dianacastillo’s picture

dianacastillo CreditAttribution: dianacastillo as a volunteer commented

This is a great help, please add this to the next version of feeds. Thanks