Problem/Motivation

Both internal and API code is using inconsistently repo and repository to refer to repository.

Proposed resolution

Use repository for all cases.

Remaining tasks

  • Removed from simple strings and from documentation blocks.
  • Changes on code variables.
  • Changes on API strings(i.e. VersioncontrolRepositoryController::entityType), which affects a lot of code.
  • Decide if we want to change reposync and repomgr. Which end up in many places too, since it's also a code name in API(i.e. ) and a ctools plugin type codename.
  • Decide if we want to change the versioncontrol_handler_filter_repo_backend class name(not sure, but I guess that also affects code exported views).

User interface changes

None.

API changes

I think it worths to create a change notice about this, since it affects API.

Original report by sdboyer

When I was working heavily on the vcapi internals, I simply couldn't bring myself to write out the full word 'repository' ten thousand times. On reading & revisiting, though, it's kinda problematic - in particular, having the backend key on 'repo' instead of 'repository' for its various arrays of entity data is a bit of a gotcha. Like, I gotcha'd myself on it the other day when trying to implement hook_query_alter(), because I was expecting 'repository' and it was actually 'repo'. All of our other entities use the full word, repositories should too.

Comments

marvil07’s picture

Priority: Normal » Major
Issue tags: +versioncontrol-6.x-2.0-release-blocker

cleaning api for an api module is important ;-)

marvil07’s picture

Where to start to look at: git grep \( -e [rR]epo \) --and --not \( -e [rR]epository -e [rR]epositories -e [Rr]epo_id \)

marvil07’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Active » Needs review
Issue tags: +Needs backport to D6
StatusFileSize
new16.94 KB

Let's do it on D7 first, then backport(so I can use testbot for patches, NR only for testbot). Please notice that I have updated the issue summary.

marvil07’s picture

Status: Needs review » Needs work
marvil07’s picture

Issue tags: +Needs change record

tagging

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new38.44 KB
new50.65 KB

Now, code variables changed too, let's see what testbot thinks.

marvil07’s picture

Issue summary: View changes

Convert to issue summary format adding relevant information.

marvil07’s picture

Status: Needs review » Needs work

Still some items to do.

marvil07’s picture

I went ahead and added the last patch to upstream. It's only cleaning anyway, but the pending changes are not, since it will involve external related projects implementing the api to change.

senpai’s picture

Issue tags: +git, +drupal.org D7

Tagging.

sdboyer’s picture

Issue tags: -git, -drupal.org D7 +vc-next

retagging.

marvil07’s picture

Removing blocker tag, since it's planned to next major version.

marvil07’s picture

Issue summary: View changes

Code variables chnaged on the last patch

  • Commit 5c414f7 on 7.x-1.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1045496: Stop using 'repo' shorthand on simple strings and...
  • Commit a7faeda on 7.x-1.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1045496: Stop using 'repo' shorthand on code variables.
    

  • Commit 5c414f7 on 7.x-1.x, repository-families by marvil07:
    Issue #1045496: Stop using 'repo' shorthand on simple strings and...
  • Commit a7faeda on 7.x-1.x, repository-families by marvil07:
    Issue #1045496: Stop using 'repo' shorthand on code variables.
    

  • marvil07 committed 5c414f7 on d8port
    Issue #1045496: Stop using 'repo' shorthand on simple strings and...
  • marvil07 committed a7faeda on d8port
    Issue #1045496: Stop using 'repo' shorthand on code variables.
    
marvil07’s picture

Issue tags: -Needs backport to D6