Problem/Motivation
Both internal and API code is using inconsistently repo and repository to refer to repository.
Proposed resolution
Use repository for all cases.
Remaining tasks
Removed from simple strings and from documentation blocks.Changes on code variables.- Changes on API strings(i.e. VersioncontrolRepositoryController::entityType), which affects a lot of code.
- Decide if we want to change reposync and repomgr. Which end up in many places too, since it's also a code name in API(i.e. ) and a ctools plugin type codename.
- Decide if we want to change the versioncontrol_handler_filter_repo_backend class name(not sure, but I guess that also affects code exported views).
User interface changes
None.
API changes
I think it worths to create a change notice about this, since it affects API.
Original report by sdboyer
When I was working heavily on the vcapi internals, I simply couldn't bring myself to write out the full word 'repository' ten thousand times. On reading & revisiting, though, it's kinda problematic - in particular, having the backend key on 'repo' instead of 'repository' for its various arrays of entity data is a bit of a gotcha. Like, I gotcha'd myself on it the other day when trying to implement hook_query_alter(), because I was expecting 'repository' and it was actually 'repo'. All of our other entities use the full word, repositories should too.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 0001-Issue-1045496-Stop-using-repo-shorthand.patch | 50.65 KB | marvil07 |
| #6 | interdiff.txt | 38.44 KB | marvil07 |
| #3 | 0001-Issue-1045496-Stop-using-repo-shorthand-on-simple-st.patch | 16.94 KB | marvil07 |
Comments
Comment #1
marvil07 commentedcleaning api for an api module is important ;-)
Comment #2
marvil07 commentedWhere to start to look at:
git grep \( -e [rR]epo \) --and --not \( -e [rR]epository -e [rR]epositories -e [Rr]epo_id \)Comment #3
marvil07 commentedLet's do it on D7 first, then backport(so I can use testbot for patches, NR only for testbot). Please notice that I have updated the issue summary.
Comment #4
marvil07 commentedComment #5
marvil07 commentedtagging
Comment #6
marvil07 commentedNow, code variables changed too, let's see what testbot thinks.
Comment #6.0
marvil07 commentedConvert to issue summary format adding relevant information.
Comment #7
marvil07 commentedStill some items to do.
Comment #8
marvil07 commentedI went ahead and added the last patch to upstream. It's only cleaning anyway, but the pending changes are not, since it will involve external related projects implementing the api to change.
Comment #9
senpai commentedTagging.
Comment #10
sdboyer commentedretagging.
Comment #11
marvil07 commentedRemoving blocker tag, since it's planned to next major version.
Comment #11.0
marvil07 commentedCode variables chnaged on the last patch
Comment #15
marvil07 commented