I had an idea regarding the views issue discussed here: http://drupal.org/node/996152
If I use the add "more link" in the panel config for a block, it is its own link and has no relation to the "more link" in the views config, and so it doesn't create the trailing nid issue when the node:nid argument is present that views does.
So, if the text of this link could be editable like the views config, then I can get around this trailing nid issue and have a "more link" that is customizable.
Maybe the same ability could be extended to both blocks and content panes from the panels config, since content panes has the same issue as well because it uses the views more link ability only.
Comment | File | Size | Author |
---|---|---|---|
#33 | diff.txt | 1.11 KB | xlin |
#33 | views_panes-more_link_text-1000146-33.patch | 3.97 KB | xlin |
#32 | views_panes-more_link_text-1000146-32.patch | 4.04 KB | xlin |
#31 | views_panes-more_link_text-1000146-31.patch | 4.03 KB | xlin |
#28 | views_panes-more_link_text-1000146-28.patch | 4 KB | cboyden |
|
Comments
Comment #1
LEternity CreditAttribution: LEternity commentedsubscribe, this is also the case for the drupal 7 version of panels.
Comment #2
BParticle CreditAttribution: BParticle commentedsubscribing
Comment #3
AaronBaumanThis would be really useful. +1
Comment #4
AaronBaumanHere's a patch against 6.x - it may apply to 7.x as well.
Surprisingly straightforward
Comment #5
merlinofchaos CreditAttribution: merlinofchaos commentedWrong project
Comment #6
bones CreditAttribution: bones commentedAgree would be very useful.
Just applied the patch and it almost works with 7.x-1.0-rc2, seems I needed to apply the same changes to the views.inc file also, but that could just be for my use case?
Also found an issue that does not allow the views read more link to display at all. Will post seperately.
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedOk, I was about to commit this, and then I realized that I think I want the ability to control the more text to be a flag on the view. Otherwise, the patch is in good shape.
Can we get that added in?
Comment #8
AaronBaumaneasy enough.
Comment #9
tim.plunkettThis should be one line.
Comment #10
AaronBaumanOops, that patch was against the wrong revisions.
This one should apply cleanly.
Comment #11
mrfelton CreditAttribution: mrfelton commentedUpdated patch to apply cleanly with git/drush. Also adds the setting in to the views config place, which seemed to have been missing before.
Comment #12
fastangel CreditAttribution: fastangel commentedThis works for me :D
Comment #13
RaulMuroc CreditAttribution: RaulMuroc commentedI think it is not correct. This patch is based on Views Pane module and it should be based on Ctools Module because it is a Ctools problem not a Views Pane problem.
Comment #14
RaulMuroc CreditAttribution: RaulMuroc commented#11: views_panes-more_link_text-1000146.11.patch queued for re-testing.
Comment #16
mrfelton CreditAttribution: mrfelton commentedUpdated patch to apply against latest -dev
Comment #17
RaulMuroc CreditAttribution: RaulMuroc commentedI test it and no "more link" appears at all but perhaps is because of my own configuration :S
Information that perhaps helps about my own config: I have a 'view: statuses stream' which filters by type 'status' showing 5 times the node. that veiws creates a block and this block is shown through panels. So it should be a "more link" linking to that view result to see all the statuses (more than 5 for sure).
Thank you.
Comment #18
RaulMuroc CreditAttribution: RaulMuroc commentedSomething can test more?
Comment #19
joel_osc CreditAttribution: joel_osc commentedThe patch works well for me using a Content Pane (not a block), in the 'Allow Settings' check both the 'more link' and the 'more text' - then you should see the more link text field show up on your pane config.
I think there is a potential improvement to the patch, and that would be to run it through the context keyword subtitution so you can place contextual information into the more link text. Here is the suggested change to the views_content_views_panes_content_type_render function in views_panes.inc:
Cheers!
Comment #22
mrjmd CreditAttribution: mrjmd commentedRe-rolled and added in the change from #19.
Comment #23
kalabroThe patch in #22no longer applies due to change in #1910608: Ajax + Allow settings: Allowed settings lost on ajax (exposed forms/pager).
Comment #24
techninja CreditAttribution: techninja at Four Kitchens commentedRerolled this patch to apply after changes mentioned in #23 :D
Comment #25
chasingmaxwell CreditAttribution: chasingmaxwell commentedFixed a typo in the previous patch.
Comment #26
lesleyfernandes CreditAttribution: lesleyfernandes commentedHey guys, this patch is working for us. Are you planning to have this feature on the 7.x-1.13 version? Thank you.
Comment #27
lesleyfernandes CreditAttribution: lesleyfernandes commentedDue the release of the new Ctools version (7.x-1.13) the patches above are not working anymore.
Comment #28
cboyden CreditAttribution: cboyden commentedHere's a patch that's rerolled against the latest dev.
Comment #29
dsnopekThe code looks good to me and works in my testing! This patch is likely to be included in Panopoly: #2968560: Allow overriding "more" text on Views-based widgets
Comment #30
dsnopekComment #31
xlin CreditAttribution: xlin as a volunteer commentedRe-roll #24 against #1910608 (patch #56),
Comment #32
xlin CreditAttribution: xlin as a volunteer commentedFix bug in patch #24. Again, use this patch ONLY if you are also using patch from https://www.drupal.org/project/ctools/issues/1910608.
Comment #33
xlin CreditAttribution: xlin as a volunteer commentedUpdated to patch #32. Since more_link and more_text are two separate options, it seems odd to have more_text depends on more_link. e.g, I want user to be able to override the more_text but not giving them the option to turn it off.