Today, Firebug reported the following error:

uncaught exception: [Exception... "Could not convert JavaScript argument arg 0 [nsIDOMViewCSS.getComputedStyle]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: http://localhost/sites/all/modules/jquery_update/replace/jquery.js?1 :: anonymous :: line 808" data: no]

This type of error happens when jQuery tries to get the position of a hidden element (see http://bugs.jquery.com/ticket/2528). In this case, the hidden element turned out to be the space between the closing div-tag and the html comment in </div> <!-- /.view --> on line 94 of zen/templates/views-view.tpl.php. A quick search revealed 20 occurrences of this pattern. I have removed all of them; patch attached.

I don't know if there is a coding standard which demands this kind of spaces, but if there is, I think it should be changed.

CommentFileSizeAuthor
zen-whitespace-comment.patch5.22 KBmarcvangend
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JohnAlbin’s picture

Status: Active » Fixed

I've never seen this error, but the space is there purely because it slightly easier to read the code, IMO.

But an actual bug trumps a stylistic preference.

Fixed. http://drupal.org/cvs?commit=501154

JohnAlbin’s picture

Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Fixed » Patch (to be ported)
JohnAlbin’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.