Remove delay() method from insert queries [#772554]

The idea behind "DELAY" is to allow queries that don't need to commit immediately to just kinda happen when they get there. However, it is not part of standard SQL. It doesn't work on PostgreSQL or SQLite. It only works on MySQL. However, it only works on the MyISAM table type. Drupal 7 on MySQL now defaults to InnoDB, where DELAY is ignored. So really, it's an edge case that we don't even use.

Should we just get rid of it and save ourselves the hassle?

Comment	File	Size	Author
#5	kill-delay.patch	2.37 KB	jbrown
#5
#1	772554-delay.patch	2.52 KB	Crell
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Crell CreditAttribution: Crell commented 18 April 2010 at 23:40

Status:

Active

» Needs review

File	Size
772554-delay.patch	2.52 KB

I couldn't find anywhere that we were using delay() in the first place.

Comment #2

chx CreditAttribution: chx commented 18 April 2010 at 23:47

Status:

Needs review

» Reviewed & tested by the community

Totally. DELAYED means "the day when my database melts down has been delayed by an undefined amount of time". Using INSERT DELAYED adds a lot of interesting problems and altogether you might end up with a lower INSERT performance. More importantly you give up control on what happens with your database. Bad idea.