If you try to enable a workflow from workflow.module to e.g. binary poll content type things will break.

After creating a poll - switching over to the "workflow" tab beside polls' "edit" it happens:
As soon as you change the workflow state and hit save - all poll options are getting deleted with a message for each.

No idey why yet - but it happens. We've removed workflow scheme for polls atm. Will inspect the problem as soon as possible - which might take a while.

CommentFileSizeAuthor
#1 advpoll-754988-1.patch4.32 KBmiro_dietiker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker’s picture

Status: Active » Needs review
FileSize
4.32 KB

Attached patch removes everything like _POST from nodeapi part and moves it towards formapi (_submit).
It still is not correctly implemented using ahah form_state. But the nodeapi now works clean for things like resave.
Therefore workflows won't break things again now.

Will someone find time to review this?

miro_dietiker’s picture

Note this related issue
#468394: Various operations on advanced polls delete choices
I didn't find it previously which led to adding this issue. Still continuing to work here for the fix.

miro_dietiker’s picture

Status: Needs review » Fixed

committed to rev 1.21.2.88.2.24

miro_dietiker’s picture

Priority: Normal » Critical
Status: Fixed » Needs work

hmm... there must be something that went wrong while testing...

after commit to -dev now all choices go away on node save... I'll work on this tomorrow.
so please don't update the module till we have a clean solution.

miro_dietiker’s picture

Priority: Critical » Normal
Status: Needs work » Fixed

Fixed again and tested in detail this time leading to 1.21.2.88.2.29.
This works now for binary and ranking poll.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.