Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Any plans? :)
http://drupal.org/project/skinr
Comment | File | Size | Author |
---|---|---|---|
#7 | zen-skinr-661628-7.patch | 4.15 KB | JohnAlbin |
#6 | zen-skinr-views.patch | 3.8 KB | Jacine |
#3 | zen-skinr.patch | 353 bytes | Jacine |
#3 | zen-skinr-views.patch | 3.83 KB | Jacine |
#5 | zen-skinr-views.patch | 3.95 KB | Jacine |
Comments
Comment #1
JohnAlbinI was just looking at this. It seems like it would be really, really easy to add this integration. Just preprocess in the $skinr variable into the $classes_array.
Anyone want to roll a patch for it? :-D
Comment #2
JacineSure, I'd love to. I'll do it this weekend. :)
Comment #3
JacineHi!
Well, I totally forgot that Zen doesn't have views template file. Panel panes work out of the box with Zen because it also uses $classes and your code takes care of it (I added it during zen_preprocess()). However, views-view.tpl.php goes the manual route.
I'm not sure if you are interested in adding the views template file, so here are 2 patches ;)
Comment #4
JacineComment #5
JacineSorry, use this one. There was a slight boo-boo in the other. Also, an unwanted side effect (in this case) the hook name gets added to the class names. I have overriding views_view, like so:
$vars['classes_array'][0] = 'view';
Not sure if that's how you would want to do it.
Comment #6
JacineHoly crap... That was the wrong patch. I need to stop doing this stuff at 4 AM. Time to go to bed. Sorry for the inbox overload.
This is the right one (hopefully).
Comment #7
JohnAlbinI updated the zen_preprocess() function to prevent PHP warnings on templates where $vars['skinr'] is undefined. I also updated the if statement so that Zen continues to skip building a $classes_array when a module is already using $classes for other uses (i.e. views-view-list.tpl.php, etc.) Also, updated comments in the tpl.
Comment #8
JohnAlbinCommitted.
Jacine, I put you in the CHANGELOG twice. :-)
Comment #9
JacineYay, awesome! Thank you :D
Comment #10
ChrisBryant CreditAttribution: ChrisBryant commentedThis is great, you guys ROCK! :-)
Thanks!!
Comment #11
JacineRe: http://twitter.com/merlinofchaos/status/7682119358
Well, I should have asked merlinofchaos before just putting this patch up, so to make up for it I wrote a patch. If he adds it, Zen wont need it but what do you think about it? http://drupal.org/node/682888
Comment #12
JohnAlbinFYI, the views-view.tpl.php that Jacine added is for Views 2.
Merlin wants to add $classes to Views 3, which is still in alpha, so its all good.