Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This patch includes a bunch of things (if you want separate issues for each item, let me know):
- I am about to use this theme, but noticed a bunch of code style issues - tabs instead of spaces, some if's without spaces after them, etc.
- There was also a bug (http://drupal.org/node/545428), that appeared in the page.tpl.php file too.
- I setup some missing settings in the .info file (using the 16 column grid as the default).
- I adjusted your default.css to float:right the search box as it appears in the middle of the screen if there are no breadcrumbs. I also changed the background colour to white, as the grey hides the default gridder module lines.
- I added some very simple padding for Ubercart product tables in custom.css
This patch is against the latest -dev release checked out via CVS (using the tag DRUPAL-6--1).
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | omega-611890.patch | 65.04 KB | davemybes |
Comments
Comment #1
davemybes CreditAttribution: davemybes commentedPatch is attached.
Comment #2
himerus CreditAttribution: himerus commentedYou are awesome! Thanks for submitting patches, I will dig into these shortly, and get them applied in my sandbox to see that things work right, and get it committed.
No doubt there are tons of things like this with so much code from so many locations. (Copy & Paste seems to suck for proper spacing & formatting)
Comment #3
davemybes CreditAttribution: davemybes commentedYa, copy and paste does sometimes have its down side :)
After your talk at Drupalcamp Montreal I was intrigued by this theme - especially with your intense settings page. Its definitely a cool feature being able to change region sizes via the settings page. And when I noticed a few code style issues, the perfectionist in me couldn't let it go. There's still a couple more areas that I want to look at e.g. having blocks in the header region (or above it), and making an easier to read settings page - I liked your idea of jquery interface with drag and drop, but my jquery sucks. I'll keep you posted if I get anything more done.
Comment #4
himerus CreditAttribution: himerus commentedFixed in 6.x-1.0-alpha4 release.
Comment #5
davemybes CreditAttribution: davemybes commentedAwesome! I'll install the new release and check it out. By the way, I would set the status to fixed, rather than closed so that its easier to find (and it shows you're "fixing" issues). The drupal scripts will automatically close the issue after 2 weeks of it being set to fixed).