LT not properly passing query strings when redirect in enabled. [#60887]

I spent most of this morning puzzling over this and have a temporary fix. The rewrite login urls option in LT screws up in conjunction with the drupal_goto call in cart.module that is invoked when a not logged in user clicks on the "checkout" button. The browser goes into an infinite reidrect loop until it times out.

Finally figured out that disabling LT's rewrite login function in config screen sorts the problem out, but of course users are then redirected to the plain old normal login screen :(

My patch is bad coding practice but works for me! Leave the LT redirect on (it seems to work in every other module) and modify the drupal_goto parameter in cart.module to point direct at the LT login url.

Options for developers:

1) Distribute this as a patch to cart.module
2) Figure out what's causing the loop and catch it in the LT code.

I figured the least I could do is offer this input in return for a (mostly) brilliant free application!

Comments

Comment #1

hunmonk CreditAttribution: hunmonk commented 20 June 2006 at 04:32

Priority:

Normal

» Minor

Comment #2

hunmonk CreditAttribution: hunmonk commented 22 June 2006 at 05:20

Title:	Redirect loop in cart	» LT not properly passing query strings when redirect in enabled.
Assigned:	Unassigned	» hunmonk
Status:	Active	» Fixed

tough problem. :) basically, the destination request from the original drupal_goto was fouling up the drupal_goto call of the LT redirect. this is fixed by specifically unsetting the destination request prior to hijacking the page. also, we really need to pass along any $_GET stuff when we hijack, so i fixed that up, too. this shouldn't be a problem at all from 4.7 forward, since we don't do any menu hijacking, but rather work with the user login forms.

fixed in 4.6.