Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When I press Preview button reply form just disappears and I need to go back to see it. This problem only exists on messages/view/[number] page.
Comment | File | Size | Author |
---|---|---|---|
#12 | fix_form_bugs1_d7.patch | 3.19 KB | Berdir |
#7 | fix_form_bugs1.patch | 3.67 KB | NaheemSays |
#2 | fix_form_bugs.patch | 3.33 KB | Berdir |
Comments
Comment #1
litwol CreditAttribution: litwol commentedComment #2
BerdirI assume this was broken by my recent patch..
When debugging this, I found out that there are actually multiple bugs...
- The mentioned visibility issue. Happens because $recipient_list is overwritten by an empty value and then '#access' is set to FALSE
- blocked recipients are not removed from the form because the call was wrong (the block implementation assumes that the key is the uid)
- There was a notice regarding the recently added read_all flag when sending a new message.
- When all recipients were blocked, the current user was displayed as only recipient. The form should be hidden in that case.
Comment #3
BerdirComment #4
NaheemSays CreditAttribution: NaheemSays commentedlooks good to me - it works and the changes look sensible. the addition of $blocked also make the "reply to self" function work how it is meant to instead of being cheeky in its implementation.
Comment #5
mr.alinaki CreditAttribution: mr.alinaki commentedPatch works for me. Thanks!
Comment #6
mr.alinaki CreditAttribution: mr.alinaki commentedPatch works for preview button, but I can't "reply to myself".
Comment #7
NaheemSays CreditAttribution: NaheemSays commentedok, it took me next to forever finding that bug. Attached patch should fix it. My modification:
as otherwise messages to self are broken when you are the only recipient.
Comment #8
litwol CreditAttribution: litwol commentedneed review for #7. i'll commit it after next rtbc.
Comment #9
BerdirTested, the change does fix the bug.
The change is required because the new code does remove the author as recipient unless (added by this patch) he is the only recipient.
Comment #10
litwol CreditAttribution: litwol commentedcheers
Comment #11
litwol CreditAttribution: litwol commentedoops
Comment #12
BerdirPatch almost applied to D7, just the small change in pm_block_user had to be rerolled and I already fixed one thing (the read_all form element placement) in D7 while porting, it seems.
Comment #13
litwol CreditAttribution: litwol commented