Ran into a bug where, by accident, I set the language of a vocabulary even though it was using the I18N_TAXONOMY_LOCALIZE mode. On vocabulary creation this isn't a problem and I went ahead and added my terms and everything was fine. Later when I updated the vocabulary to add it to a new content type, all of the vocabulary's terms were incorrectly set to the language I had set the vocabulary to on creation.

This behavior doesn't make sense for any mode besides I18N_TAXONOMY_LANGUAGE and the included patch stops this from happening.

CommentFileSizeAuthor
#2 i18n_dontsetlang2.patch2.48 KBandrewlevine
i18n_dontsetlang.patch1.68 KBandrewlevine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jose Reyero’s picture

Jose Reyero CreditAttribution: Jose Reyero commented
Status: Needs review » Needs work

Agree, that's just because I'm a lazy guy and the form doesn't have prover validation.

I you want to implement the form validation, and/or add some js...

andrewlevine’s picture

andrewlevine CreditAttribution: andrewlevine commented
Status: Needs work » Needs review
FileSize
i18n_dontsetlang2.patch2.48 KB

Jose, attached is the patch using form validation and Javascript

andrewlevine’s picture

andrewlevine CreditAttribution: andrewlevine commented

Forgot to mention, this patch applies to 6.x-1.x-dev with a fuzz factor (I wrote it against a non-dev version), but I've tested it on dev and it works fine.

Jose Reyero’s picture

Jose Reyero CreditAttribution: Jose Reyero commented
Status: Needs review » Fixed

Great patch. Just added some more validation for the left case (no language selected).

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.