When I click 'Delete message', the question on confirmation screen is: 'Are you sure you want to delete' (and nothing more). This is really how the code handle that, there's no other missing/intended part of that string to be seen in code.
At the very minimum, it should have a question mark.
Better, it should say *what* is about to be deleted. Simple way out is to say 'Are you sure you want to delete the message?' or similar. Ideally, we might want to include the actual title of the message, but that would need a bit of extra code to load.
I'm not rolling a patch now, as this is minor, and I'll re-write that string through localization anyway - but I'm reporting the bug here, just in case.
Comment | File | Size | Author |
---|---|---|---|
#2 | privatemsg_delete_screens.patch | 1.55 KB | Berdir |
Comments
Comment #1
BerdirI agree.
A similiar thing is the "this action cannot be undone" warning when you block a user, hower, that is simply wrong... :)
Comment #2
BerdirString issues are usually not as easy as they look ;)
I think it does not make sense tu use the message title, because visually, to the user, only the thread has a title, not a single message. So that might be confusing...
Also removed the description from the block user screen, The current is wrong and I can't come up with a better one.
Comment #3
JirkaRybka CreditAttribution: JirkaRybka commentedMakes sense, and simple patch... I see this as RTBC.
Comment #4
litwol CreditAttribution: litwol commentedCheers