The permission names used by gmap_location are very non-Drupalish.

- "show node map" and "show user map" should be "view node map" and "view user map".

- "user locations" is unclear; I didn't know what it meant until I looked it up in the code. I guess this should be renamed to something like "view user location details".

Comments

gaele’s picture

gaele CreditAttribution: gaele commented

Just noticed that "set user location" isn't used at all. So this permission can be removed.

bdragon’s picture

bdragon CreditAttribution: bdragon commented

Hmm, you're right, 'set user location' is a leftover bit from the bad old days where GMap used to be the one responsible for user locations.

http://drupal.org/cvs?commit=183000

Looking into the feasibility of the other changes...

bdragon’s picture

bdragon CreditAttribution: bdragon commented
Status: Active » Fixed

OK, grepped through contrib and did the rest.

http://drupal.org/cvs?commit=183034
http://drupal.org/cvs?commit=183042

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.