Ad type AHAH switcher [#382928]

I made an AHAH-based Ad type switcher. It allows to choose Ad type during the addition step. Sub-content types no more needed to create ads.

Comment	File	Size	Author
#14	ad.module.patch	6.82 KB	neochief
#9	ad.module_AHAH_switcher.patch	6.92 KB	neochief
#4	ad_type_switch_0_0.patch	8.07 KB	neochief
#3	ad_type_switch.patch	8.07 KB	neochief
#2	ad_type_switch.patch	7.58 KB	neochief
	ad_type_switch.patch	7.42 KB	neochief

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

neochief CreditAttribution: neochief commented 25 February 2009 at 00:20

Also included minor fix for ad_text (see patch's tail).

Comment #2

neochief CreditAttribution: neochief commented 25 February 2009 at 00:29

File	Size
ad_type_switch.patch	7.58 KB

Ah, sorry, as ussual, missed some gotcha. Here's a better version.

File	Size
ad_type_switch.patch	8.07 KB

File	Size
ad_type_switch_0_0.patch	8.07 KB

Comment #5

Jeremy CreditAttribution: Jeremy commented 27 February 2009 at 18:16

Status:

Needs review

» Needs work

When applying this patch, ad creation is overwhelmed with PHP notices which were previously fixed. Some samples:

    * notice: Undefined property: stdClass::$adtype_select in /var/www/ad69/sites/default/modules/ad/ad.module on line 618.
    * notice: Undefined property: stdClass::$adtype in /var/www/ad69/sites/default/modules/ad/ad.module on line 631.
    * notice: Undefined property: stdClass::$nid in /var/www/ad69/sites/default/modules/ad/ad.module on line 655.
    * notice: Undefined property: stdClass::$adstatus in /var/www/ad69/sites/default/modules/ad/ad.module on line 655.
    * notice: Undefined property: stdClass::$adstatus in /var/www/ad69/sites/default/modules/ad/ad.module on line 660.
    * notice: Undefined property: stdClass::$adstatus in /var/www/ad69/sites/default/modules/ad/ad.module on line 660.
    * notice: Undefined property: stdClass::$adstatus in /var/www/ad69/sites/default/modules/ad/ad.module on line 660.
    * notice: Undefined property: stdClass::$adstatus in /var/www/ad69/sites/default/modules/ad/ad.module on line 660.
    * notice: Undefined property: stdClass::$adstatus in /var/www/ad69/sites/default/modules/ad/ad.module on line 660.
    * notice: Undefined property: stdClass::$adstatus in /var/www/ad69/sites/default/modules/ad/ad.module on line 660.
    * notice: Undefined property: stdClass::$nid in /var/www/ad69/sites/default/modules/ad/ad.module on line 685.

When I try and select the advertisement type, I get an error too big to display on my screen and the ad type is not selected. It starts as follows:

An error occurred. 
/ad69/node/add/ad/ahah
&lt;!DOCTYPE html PUBLIC &quot;-//W3C//DTD XHTML 1.0 Strict//EN&quot;
  &quot;http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd&quot;&gt;
&lt;html xmlns=&quot;http://www.w3.org/1999/xhtml&quot; xml:lang=&quot;en&quot; lang=&quot;en&quot; dir=&quot;ltr&quot;&gt;
  &lt;head&gt;
    &lt;title&gt;Create Advertisement | localhost&lt;/title&gt;
    &lt;meta http-equiv=&quot;Content-Type&quot; content=&quot;text/html; charset=utf-8&quot; /&gt;
&lt;link rel=&quot;shortcut icon&quot; href=&quot;/ad69/misc/favicon.ico&quot; type=&quot;image/x-icon&quot; /&gt;
    &lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/node/node.css?K&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/system/defaults.css?K&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/system/system.css?K&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/system/system-menus.css?K&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/user/user.css?K&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/themes/garland/style.css?K&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;print&quot; href=&quot;/ad69/themes/garland/print.css?K&quot; /&gt;
    &lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/jquery.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/drupal.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/tabledrag.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/jquery.form.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/ahah.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/progress.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/autocomplete.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/collapse.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/textarea.js?K&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot;&gt;
&lt;!--//--&gt;&lt;![CDATA[//&gt;&lt;!--
jQuery.extend(Drupal.settings, { &quot;basePath&quot;: &quot;/ad69/&quot;, &quot;ahah&quot;: { &quot;edit-adtype-submit&quot;: { &quot;url&quot;: &quot;/ad69/node/add/ad/ahah&quot;, &quot;event&quot;: &quot;mousedown&quot;, &quot;keypress&quot;: true, &quot;wrapper&quot;: &quot;adtype-ahah-wrapper&quot;, &quot;selector&quot;: &quot;#edit-adtype-submit&quot;, &quot;effect&quot;: &quot;none&quot;, &quot;method&quot;: &quot;replace&quot;, &quot;progress&quot;: { &quot;type&quot;: &quot;throbber&quot; }, &quot;button&quot;: { &quot;op&quot;: &quot;Select&quot; } }, &quot;edit-attach&quot;: { &quot;url&quot;: &quot;/ad69/upload/js&quot;, &quot;event&quot;: &quot;mousedown&quot;, &quot;keypress&quot;: true, &quot;wrapper&quot;: &quot;attach-wrapper&quot;, &quot;selector&quot;: &quot;#edit-attach&quot;, &quot;effect&quot;: &quot;none&quot;, &quot;method&quot;: &quot;replace&quot;, &quot;progress&quot;: { &quot;type&quot;: &quot;bar&quot;, &quot;message&quot;: &quot;Please wait...&quot; }, &quot;button&quot;: {

Finally, the "fix" for the ad_text module seems to be totally unrelated to this patch -- please open a new issue and explain how it is a fix. What problem is it fixing?

Comment #6

Jeremy CreditAttribution: Jeremy commented 27 February 2009 at 19:42

These notices were evidently introduced earlier by me in the 6.x-2.x-dev branch. I am fixing them to address another bug, and hope to commit the fix soon. I will retry your patch at that time.

Comment #7

Jeremy CreditAttribution: Jeremy commented 5 March 2009 at 22:35

Repeating my question from before: "the 'fix' for the ad_text module seems to be totally unrelated to this patch -- please open a new issue and explain how it is a fix. What problem is it fixing?"

Comment #8

Jeremy CreditAttribution: Jeremy commented 5 March 2009 at 22:38

This patch still doesn't work -- when I try selecting an ad type, I get a full screen of errors as described above. Note that I have enabled PHP E_ALL, and as the module is nearly 100% working with E_ALL I don't want to fall back to having it not work in this configuration.

I can not merge this patch until it works.

Comment #9

neochief CreditAttribution: neochief commented 6 March 2009 at 12:48

Status:

Needs work

» Needs review

File	Size
ad.module_AHAH_switcher.patch	6.92 KB

I rerolled patch, but I still have nothing with E_ALL enabled. Everything works just fine.

Comment #10

Jeremy CreditAttribution: Jeremy commented 6 March 2009 at 15:44

When I go to "Create Content -> Advertisement" I see the following:

    * notice: Undefined property: stdClass::$adtype_select in /var/www/ad69/sites/default/modules/ad/ad.module on line 620.
    * notice: Undefined property: stdClass::$adtype in /var/www/ad69/sites/default/modules/ad/ad.module on line 633.

When I try to actually select an ad type, I get more errors that fits on my screen, and as it's a popup I'm unable to scroll it for all of the errors. They start as follows:

An error occurred. 
/ad69/node/add/ad/ahah
&lt;!DOCTYPE html PUBLIC &quot;-//W3C//DTD XHTML 1.0 Strict//EN&quot;
  &quot;http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd&quot;&gt;
&lt;html xmlns=&quot;http://www.w3.org/1999/xhtml&quot; xml:lang=&quot;en&quot; lang=&quot;en&quot; dir=&quot;ltr&quot;&gt;
  &lt;head&gt;
    &lt;title&gt;Create Advertisement | localhost&lt;/title&gt;
    &lt;meta http-equiv=&quot;Content-Type&quot; content=&quot;text/html; charset=utf-8&quot; /&gt;
&lt;link rel=&quot;shortcut icon&quot; href=&quot;/ad69/misc/favicon.ico&quot; type=&quot;image/x-icon&quot; /&gt;
    &lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/node/node.css?N&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/system/defaults.css?N&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/system/system.css?N&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/system/system-menus.css?N&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/modules/user/user.css?N&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;/ad69/themes/garland/style.css?N&quot; /&gt;
&lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;print&quot; href=&quot;/ad69/themes/garland/print.css?N&quot; /&gt;
    &lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/jquery.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/drupal.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/tabledrag.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/jquery.form.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/ahah.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/progress.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/autocomplete.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/collapse.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot; src=&quot;/ad69/misc/textarea.js?N&quot;&gt;&lt;/script&gt;
&lt;script type=&quot;text/javascript&quot;&gt;
&lt;!--//--&gt;&lt;![CDATA[//&gt;&lt;!--
jQuery.extend(Drupal.settings, { &quot;basePath&quot;: &quot;/ad69/&quot;, &quot;ahah&quot;: { &quot;edit-adtype-submit&quot;: { &quot;url&quot;: &quot;/ad69/node/add/ad/ahah&quot;, &quot;event&quot;: &quot;mousedown&quot;, &quot;keypress&quot;: true, &quot;wrapper&quot;: &quot;adtype-ahah-wrapper&quot;, &quot;selector&quot;: &quot;#edit-adtype-submit&quot;, &quot;effect&quot;: &quot;none&quot;, &quot;method&quot;: &quot;replace&quot;, &quot;progress&quot;: { &quot;type&quot;: &quot;throbber&quot; }, &quot;button&quot;: { &quot;op&quot;: &quot;Select&quot; } }, &quot;edit-attach&quot;: { &quot;url&quot;: &quot;/ad69/upload/js&quot;, &quot;event&quot;: &quot;mousedown&quot;, &quot;keypress&quot;: true, &quot;wrapper&quot;: &quot;attach-wrapper&quot;, &quot;selector&quot;: &quot;#edit-attach&quot;, &quot;effect&quot;: &quot;none&quot;, &quot;method&quot;:

I am unable to select an ad type with this patch applied.