Missing htmlenetiies() for locale strings [#3786]

Comment	File	Size	Author
#5	drupal_5	1.09 KB	killes@www.drop.org

Comment #1

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 25 October 2003 at 14:25

Many of the locale strings have HTML in them (most of the admin help screens for example). Why would it be good to htmlspecialchars() them?

Log in or register to post comments

Comment #2

(not verified) CreditAttribution: commented 28 October 2003 at 09:08

I would say that entities should be filtered, but not tags.
So replace è by è but not by <b>
Is this what you meant?

Bèr

Log in or register to post comments

Comment #3

(not verified) CreditAttribution: commented 28 October 2003 at 09:12

Doh. Of course the filters are enabled on drupal.org. :) Again:

I would say that entities should be filtered, but not tags.
So replace è by è but not <b> by <b>
Is this what you meant?

Log in or register to post comments

Comment #4

Kjartan CreditAttribution: Kjartan commented 28 October 2003 at 10:10

I feel the whole string should be converted, including all tags. The tags are a part of what needs to be translated so they are important information to get to the user. In any case there should be no markup in translated strings IMO, in most cases there are better solutions.

You also have cases like none enclosed as a tag, which is a value and not a html tag, its very hard to ensure that in this case the none is visible and valid tags are not. It also cleares up why the same string shows up twice in the translation listing, ive had cases where some modules have wrapped a span in a t(), but with the same text that is being used else where. Until I figured out there was a span there it was confusing as to why the same string shows up twice.