breadcrumb often broken when zen_breadcrumb_title is on [#374349]

The last breadcrumb for all taxonomy terms are now "Taxonomy term", which is not very useful, when zen_breadcrumb_title is on. It used to be the title of the term in beta3.

Examples:
1.0: the breadcrumb for taxonomy/term/2 is "Home › Taxonomy term"
1.0-beta3: the breadcrumb for taxonomy/term/2 was "Home › Title"

I've noticed that these lines were removed from zen_preprocess_page() in template.php:

  // Add an optional title to the end of the breadcrumb.
  if (theme_get_setting('zen_breadcrumb_title') && $vars['breadcrumb']) {
    $vars['breadcrumb'] = substr($vars['breadcrumb'], 0, -6) . $vars['title'] . '</div>';
  }

Comment	File	Size	Author
#7	title-in-breadcrumb-374349-7.patch	788 bytes	JohnAlbin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #2

JohnAlbin

he/they/他

English

Taipei, Taiwan

CreditAttribution: JohnAlbin commented 18 March 2009 at 00:26

Title:

last breadcrumb for all taxonomy terms are now "Taxonomy term" when zen_breadcrumb_title is on

» breadcrumb often broken when zen_breadcrumb_title is on

Marked #405444: "Forum" appears instead of container or forum name in breadcrumb as a dupe of this one.

And, yeah, that's a bug alright. Looks like I didn't test #343945: Fix zen_breadcrumb_title setting to use proper menu_get_active_item() enough. :-(

Comment #3

Edlund CreditAttribution: Edlund commented 19 March 2009 at 08:00

I had the problem with views in general and these two pieces of code solved the problem, so now the bread crumb looks right both for page/story nodes and for views.

Comment #4

aharown07 CreditAttribution: aharown07 commented 21 March 2009 at 22:05

I'm not clear on where to put the code... I'm using a subtheme based on zen classic, if that matters

Comment #5

aharown07 CreditAttribution: aharown07 commented 21 March 2009 at 22:33

OK, comparing 1.0 beta3, I can tell that the lines in the original post go immediately after function zen_preprocess_page<code(&$vars, $hook) { and before //add conditional stylesheets

Found the other also. It begins at the commented line //$trailing_separator = $title = '';

I can verify that these changes also produce very good results in the forums.

Comment #6

Jolidog CreditAttribution: Jolidog commented 14 April 2009 at 11:02

I don't know if it's related, or if I should open a new issue, but the breadcrumbs are showing a trailing when viewing a view without a title defined.

I know there are problems with views and breadcrumbs. I'm trying to solve them using the custom breadcrumb module, but the behavior indicated above happens without any other module interfering with the breadcrumbs.

Should there be a check to see if a view has a title, before adding a trailing in the end?
I don't know of any other content that exists without a title but this probably should be a general setting and not dependent on views.