I had this site which I needed to develop, which demanded RTL admin pages (hebrew in my case) . As a good drupal developer I used dpm() a lot, only to realize it's really useless in RTL mode, so I forced it to be LTR always.

I am attaching an ugly patch to krumo, which IMHO can be cleaned up a little. If you want to include such patch, just speak and I will clean it up. Otherwise, please close and re-direct me upstream. IMHO I should work directly with krumo devs, but as always sourceforce is giving me a null site...

CommentFileSizeAuthor
#4 krumo-ltr-v2.patch1.75 KBelcuco
#4 krumo-ltr-v3.patch405 byteselcuco
krumo-ltr.patch2 KBelcuco
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Active » Needs review

Anyone available to review this?

krumo project does seem dead though you can get some info at http://freshmeat.net/projects/krumo/

elcuco’s picture

elcuco CreditAttribution: elcuco commented

Moshe, I understand that there is a need for this... would you like me to clean it up, and attach a new patch? IMHO, even if upstream is "dead", our internal fork should be maintained.

I will try to contact the developers... even tough this project (krumo) did not release anything new in the last year and a half.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

yes, please do clean and re-submit. thanks.

elcuco’s picture

elcuco CreditAttribution: elcuco commented
FileSize
krumo-ltr-v3.patch405 bytes
krumo-ltr-v2.patch1.75 KB

Hi Moshe

I am attaching here 2 patchs:
* v2 sets the css to LTR to div.krumo-root for all skins
* v3 sets the dir property of div.krumo-root to be LTR in code - this way, even if somehow the css is not loaded the display will be ok.

both patch are independent, and IMHO only v3 is needed, but there is no harm in applying both.

Just for the pedants, these patches are under the GPLv2 same as the original code, not that it can be done in any other way...)

Now we need to find "upstream" and give these patches to them.

drewish’s picture

drewish CreditAttribution: drewish commented
Version: 6.x-1.13 » 7.x-1.x-dev

I think this would need to go into HEAD first and then be backported.

elcuco’s picture

elcuco CreditAttribution: elcuco commented

Drewish, that would be great in theory. In practice I assume there are no RTL testers in D7. Even in D6 is still having issues: only recently views has been fixed for RTL support (s/float:left/float:right/g). I am really new to Drupal, and I have no experience with D5, but from my understanding D5 has better Hebrew/RTL support then D6.

If we want people to start migrating from D5 to D6 (not talking about D7 which is supposed to get out "soon"!) we need to help them debug.

Saying that, whatever you decide is good for me :)

(reminder to self: the new devel/D6 module has an option to display the dumps in "php mode"... it uses a 

 tag... that also needs to be forced to LTR)
moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Fixed

Committed #3. Thanks.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Title: Froce krumo to be LTR even on RTL pages » Force krumo to be LTR even on RTL pages
elcuco’s picture

elcuco CreditAttribution: elcuco commented

Toda Moshe!

Where did you commit? Will I see this in D6 on the next release of devel?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.