The Playwright tests in multivaluePropTypes.spec.ts could do with a refactor as they're consistently failing. There are a number of helper functions in a separate file which should either be ported to the main Canvas fixture object, or simplified. They're also too small i.e. each test is installing a new instance of Drupal so the current structure isn't very efficient
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
penyaskitoRelated: #3586022: Fix multivalue-form-design*.cy.js flakiness
We have a mix of Playwright and Cypress tests here, and all flaky.
Comment #4
justafishComment #5
wim leers@justafish: thoughts on #3586022: Fix multivalue-form-design*.cy.js flakiness?
Holy shit:
tests/src/Playwright/tests/isolatedPerTest/multivaluePropTypes.spec.tshas a diffstat of+425,-2010and another+0,-294for deleting its helpers.Wow.
I think this merits a review from @narendraR, who approved adding these originally in #3577946: Remove Canvas Dev Mode flag for Multi-Value Props support. This almost sounds too good to be true.
Comment #6
justafishthere is a lot of unnecessary repeats of happy-path tests in the existing one e.g. full component lifecycle like add, drag etc on every single type when they're using the same wrapper (e.g. Float vs Integer). I've replaced that with more specific tests for where those things deviate from each other, and some additional ones on top of that where I noticed different behaviours between types whilst manually testing, which has surfaced some bugs:
https://www.drupal.org/project/canvas/issues/3586357
https://www.drupal.org/project/canvas/issues/3586358
https://www.drupal.org/project/canvas/issues/3586289
https://www.drupal.org/project/canvas/issues/3586848
I've left @todos and commented out tests where relevant in this PR for the above issues (since they're already passing when they shouldn't be then there's no regression in coverage)
Comment #8
justafish