Overview

As with #3585992: Fix undo-redo.cy.js flakyness, multivalue-form-design*.cy.js are flaky.

Proposed resolution

Fix them.

User interface changes

None

Issue fork canvas-3586022

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
Issue tags: -JavaScript +JavaScript

The waitForPreview helpers registered cy.intercept after typeInRow already pressed Enter, so the preview POST could fire before the alias existed and cy.wait('@updatePreview') could hang or miss it. The cy.get(document.activeElement).blur() inside was a no-op — document.activeElement was evaluated synchronously at queue-build time and resolved to <body>, not the popover input.

Collapsed intercept + action into a single typeInRow{,Url}AwaitPreview helper (register first, wait after), replaced the drag-and-drop cy.wait(1000) with a previewAfterDnd intercept around realDnd, and made confirmInputs retryable via per-row should('have.text', ...) instead of a one-shot .then(expect(...)).

penyaskito opened merge request !950

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -JavaScript +JavaScript
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » penyaskito
Status: Reviewed & tested by the community » Needs work
Related issues: +#3585979: CI: review automatic jobs and when they run

Don't we need at least one front-end person to review this first?

Also: not yet green. Timed out. #3585979: CI: review automatic jobs and when they run landed since this MR was opened, that is likely to help?

hooroomoo made their first commit to this issue’s fork.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: penyaskito » Unassigned
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.