Overview

The issue involves removing the canvas_dev_mode flag for the Multi-value props support features. This change is necessary to transition these features into a production phase.

Context

The canvas_dev_mode flag was initially used for development and internal testing purposes. Its removal is essential for enabling Multi-value props support in a production environment without requiring the entire Canvas Dev Mode module.

Acceptance criteria

  • Remove the canvas_dev_mode flag for Multi-value props support.
  • Ensure that Multi-value props can be used in production without enabling the entire Canvas Dev Mode module.
  • Ensure multi-value checkbox in code component is available for supported prop types only stated below:.
    • Text
    • Date
    • Integer
    • Number
    • Image
    • Video

Additional Steps

Issue fork canvas-3577946

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

vipin.mittal18 created an issue. See original summary.

vipin.mittal18’s picture

Issue summary: View changes

utkarsh_33 made their first commit to this issue’s fork.

bnjmnm’s picture

StatusFileSize
new55.21 KB

Test Help

In a Zoom meeting it was mentioned the test fails were not verbose enough to show the comparison fail. Fortunately, it looks like this is already in the terminal output (for the most recent run it is line 3508)

  cy:command ✘  assert	expected **[ Array(3) ]** to deeply equal **[ Array(3) ]**
                    Actual: 	["Marshmallow Coast","Neutral Milk Hotel","The Olivia Tremor Control"]
                    Expected: 	["Marshmallow Coast","The Olivia Tremor Control","Neutral Milk Hotel"]

Caution

The e2e tests are currently only testing multivalue entity fields, they do not cover multivalue props. These tests were added in "ui only" issues created before multivalue props were even supported, so that's reasonable.

It will be risky to remove the dev flags without having e2e tests that include actual multivalue props. The functionality is largely shared, but there are enough differences that to justify distinct tests. For example, I'm running into a problem with weight select appearing in inputs added via "add new" with multivalue link props: multivalue link problem

narendrar made their first commit to this issue’s fork.

utkarsh_33’s picture

The issue that @bnjmnm reported in #5 related to flickering and row weight will be fixed as a part of #3579026: UI Flickering When Adding or Removing Items in Multi-Value Props.

utkarsh_33’s picture

A couple of playwright tests are skipped because of a bug that is solved as a part of #3582883: [PP1] Multi-value Prop date field populates random date instead of remaining empty. I have added a todo in the issue as well. Also i verified by applying the patch that the tests that are skipped as a part of this issue are passing after applying changes from #3582883: [PP1] Multi-value Prop date field populates random date instead of remaining empty.

utkarsh_33’s picture

Status: Active » Needs review

Addressed all the feedbacks and CI is also green. Marking it NR.

narendrar’s picture

Status: Needs review » Reviewed & tested by the community

Moving this to RTBC to get the current test MR merged. We can revert the status to 'Needs work' once this is committed to handle the remaining tasks.

tim.plunkett made their first commit to this issue’s fork.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Needs work

Merged !851, let's continue with !817

  • tim.plunkett committed e1f1982c on 1.x
    chore(Multi-Value Props): #3577946 Fix e2e test coverage
    
    By: tim....

wim leers’s picture

Component: Code » Redux-integrated field widgets
Issue tags: +Needs title update, +Needs issue summary update
Related issues: +#3581110: Add Multi-Value List Text/Integer Prop Support (UI)

@tedbow asked me to look at this.

The issue title + summary do not match what MR !996 is doing. Apparently type: string|int, enum: […] are out of scope for this issue, and are being handled in #3581110: Add Multi-Value List Text/Integer Prop Support (UI)?

That's fine, but the current issue title + summary make it sound like this is the final issue.

utkarsh_33 changed the visibility of the branch 3577946-remove-canvas-dev-flag to hidden.

utkarsh_33’s picture

Hiding the new branch as it MR 817 is rebased correctly now.

Also I wanted to highlight the reason behind this commit is that we are keeping the allow multiple checkbox behind the dev-flag so this won't be exposed in any form.
We can un-skip the tests once #3581110: Add Multi-Value List Text/Integer Prop Support (UI) is fixed.

utkarsh_33’s picture

@wimleers sorry for the Mess, I closed the branch you reviewed. Would you like me to add you back to reviewer on the active branch?

wim leers’s picture

Title: Remove Canvas Dev Mode flag for Multi-Value Props support » [PP-2] Remove Canvas Dev Mode flag for Multi-Value Props support

@tedbow has indicated he believes this should only land after #3577946 #3516754: Finalize how we ascertain a `type: array` (aka multiple-cardinality) SDC/JS prop value is empty. Reflecting that.

@utkarsh_33 That's … unfortunate. 😅 But fortunately, the mere 2 comments I left on !996 are literally on code that is present there as well. Why didn't you just transplant those yourself?

P.S.: Please don't just hide the branch, also close every obsolete MR 🙏

Also I wanted to highlight the reason behind this commit is that we are keeping the allow multiple checkbox behind the dev-flag so this won't be exposed in any form.

Yes, I already deduced that from reading/reviewing the MR (both MRs now…). What I'm saying is that the title + IS should reflect that.

tedbow made their first commit to this issue’s fork.

wim leers’s picture

Title: [PP-2] Remove Canvas Dev Mode flag for Multi-Value Props support » Remove Canvas Dev Mode flag for Multi-Value Props support

bnjmnm changed the visibility of the branch 3577946-pregame to hidden.

bnjmnm’s picture

Status: Needs work » Needs review
bnjmnm’s picture

Issue summary: View changes

tim.plunkett’s picture

Status: Needs review » Fixed
Issue tags: -Needs title update, -Needs issue summary update

Merged!

Removing these tags since they were under the assumption that #3581110: Add Multi-Value List Text/Integer Prop Support (UI) wasn't going to be merged first.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.