Fixed
Project:
Drupal Canvas
Version:
1.x-dev
Component:
Redux-integrated field widgets
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Mar 2026 at 12:40 UTC
Updated:
30 Apr 2026 at 11:46 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vipin.mittal18Comment #5
bnjmnmTest Help
In a Zoom meeting it was mentioned the test fails were not verbose enough to show the comparison fail. Fortunately, it looks like this is already in the terminal output (for the most recent run it is line 3508)
Caution
The e2e tests are currently only testing multivalue entity fields, they do not cover multivalue props. These tests were added in "ui only" issues created before multivalue props were even supported, so that's reasonable.
It will be risky to remove the dev flags without having e2e tests that include actual multivalue props. The functionality is largely shared, but there are enough differences that to justify distinct tests. For example, I'm running into a problem with weight select appearing in inputs added via "add new" with multivalue link props:
Comment #7
utkarsh_33 commentedThe issue that @bnjmnm reported in #5 related to flickering and row weight will be fixed as a part of #3579026: UI Flickering When Adding or Removing Items in Multi-Value Props.
Comment #9
utkarsh_33 commentedA couple of playwright tests are skipped because of a bug that is solved as a part of #3582883: [PP1] Multi-value Prop date field populates random date instead of remaining empty. I have added a todo in the issue as well. Also i verified by applying the patch that the tests that are skipped as a part of this issue are passing after applying changes from #3582883: [PP1] Multi-value Prop date field populates random date instead of remaining empty.
Comment #10
utkarsh_33 commentedAddressed all the feedbacks and CI is also green. Marking it NR.
Comment #11
narendrarMoving this to RTBC to get the current test MR merged. We can revert the status to 'Needs work' once this is committed to handle the remaining tasks.
Comment #14
tim.plunkettMerged !851, let's continue with !817
Comment #17
wim leers@tedbow asked me to look at this.
The issue title + summary do not match what MR !996 is doing. Apparently
type: string|int, enum: […]are out of scope for this issue, and are being handled in #3581110: Add Multi-Value List Text/Integer Prop Support (UI)?That's fine, but the current issue title + summary make it sound like this is the final issue.
Comment #19
utkarsh_33 commentedHiding the new branch as it MR 817 is rebased correctly now.
Also I wanted to highlight the reason behind this commit is that we are keeping the allow multiple checkbox behind the dev-flag so this won't be exposed in any form.
We can un-skip the tests once #3581110: Add Multi-Value List Text/Integer Prop Support (UI) is fixed.
Comment #20
utkarsh_33 commented@wimleers sorry for the Mess, I closed the branch you reviewed. Would you like me to add you back to reviewer on the active branch?
Comment #21
wim leers@tedbow has indicated he believes this should only land after
#3577946#3516754: Finalize how we ascertain a `type: array` (aka multiple-cardinality) SDC/JS prop value is empty. Reflecting that.@utkarsh_33 That's … unfortunate. 😅 But fortunately, the mere 2 comments I left on !996 are literally on code that is present there as well. Why didn't you just transplant those yourself?
P.S.: Please don't just hide the branch, also close every obsolete MR 🙏
Yes, I already deduced that from reading/reviewing the MR (both MRs now…). What I'm saying is that the title + IS should reflect that.
Comment #23
wim leers#3516754: Finalize how we ascertain a `type: array` (aka multiple-cardinality) SDC/JS prop value is empty landed!
Comment #26
bnjmnmComment #27
bnjmnmComment #29
tim.plunkettMerged!
Removing these tags since they were under the assumption that #3581110: Add Multi-Value List Text/Integer Prop Support (UI) wasn't going to be merged first.