Problem/Motivation

In #3582610: Rename gin in comments, Gin references in comments were renamed.

Seems like the gin_preprocess_ or other gin_ mentions in comments were missed/skipped. We should correct these to point to the correct hook names. For example:

  • gin_preprocess_block_content_add_list
  • gin_form_node_form_alter
  • ...

There seems to be 24 occurences of gin_ hooks references in comments. Plus 2 references to gin_actions (link) and gin_sidebar (link) (but these two are questionable, as there are still form elements with the same names, so probably something for another issue).

Steps to reproduce

Proposed resolution

Find all occurences and replace to correct hooks names.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3584302-nr-bot_a6jfqejk.txt91 bytesneeds-review-queue-bot
#6 3584302-nr-bot_2zb_mi7b.txt549 bytesneeds-review-queue-bot

Issue fork drupal-3584302

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

poker10 created an issue. See original summary.

quietone made their first commit to this issue’s fork.

quietone opened merge request !15441

quietone’s picture

quietone commented
Status: Active » Needs review

@poker10, thanks for making this issue.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

The usage of parentheses with @see is inconsistent.

Some lines opt for

@see \Drupal\default_admin\Hook\PreprocessHooks::preprocessInput()

Others in Drupal sometimes use:

@see ...::preprocessInput

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3584302-nr-bot_2zb_mi7b.txt549 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Needs review
quietone’s picture

quietone commented

@sivaji_ganesh_jojodae, thanks. I did forget to add the "()" at the end.

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Applied the MR and did a phpstorm search for gin_ and all instances referencing hooks appears to be replaced.

Applied 3 missing (), rest LGTM.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3584302-nr-bot_a6jfqejk.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs work » Needs review

I've resolved merge conflicts and rebased the branch.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The rebase appears to be correct. It's kind of a pain to figure it out because part of the commit history is inaccessible now. But I did my best to check it based on the couple of pre-rebase commit links that are accessible from here in the issue log. I did a before/after comparison of the code. Nothing looks out of place. So I think this is good to be RTBC again.

amateescu made their first commit to this issue’s fork.

amateescu’s picture

amateescu commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 3301cb4 to main and 034e955 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15441

  • amateescu committed 034e955b on 11.x 
    task: #3584302 Update referenced Gin hooks in comments

By: poker10
By:...

  • amateescu committed 3301cb41 on main 
    task: #3584302 Update referenced Gin hooks in comments

By: poker10
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.