Problem/Motivation

Steps to reproduce

Proposed resolution

Rename Gin in comments where it refers to the name of the theme, not a machine name or part of a function.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582610

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15312

quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

I've been trying to get my grep skills up and disclosure used AI to help write that.

grep -rn "^\s*#.*\bgin\b\|^\s*//.*\bgin\b\|^\s*\*.*\bgin\b" core/themes/default_admin

Which wasn't perfect

❯ core/themes/default_admin/migration/css/layout/top_bar.css:171:#block-gin-page-title {                                                                                                                
  core/themes/default_admin/migration/css/components/sidebar.css:1:#gin-sidebar-draggable {                                                                                                             
  core/themes/default_admin/migration/css/components/sidebar.css:14:  #gin-sidebar-draggable {                                                                                                          
  core/themes/default_admin/migration/css/components/sidebar.css:19:#gin-sidebar-draggable:hover {                                                                                                      
  core/themes/default_admin/migration/css/components/sidebar.css:23:#gin-sidebar-draggable:active {                                                                                                     
  core/themes/default_admin/migration/css/components/dialog.css:247:#drupal-modal .gin-sticky-form-actions.form-actions {                                                                               
  core/themes/default_admin/migration/css/components/settings_tray.css:1:#gin-toolbar-bar.js-settings-tray-edit-mode button.toolbar-icon.toolbar-icon-edit.toolbar-item.is-active {                     
  core/themes/default_admin/migration/css/components/settings_tray.css:5:#gin-toolbar-bar.js-settings-tray-edit-mode {                                                                                  
  core/themes/default_admin/migration/css/components/settings_tray.css:9:#gin-toolbar-bar.js-settings-tray-edit-mode button.toolbar-icon.toolbar-icon-edit.toolbar-item.is-active:hover {               
  core/themes/default_admin/migration/css/components/settings_tray.css:13:#gin-toolbar-bar {                                                                                                            
  core/themes/default_admin/migration/css/components/settings_tray.css:17:#gin-toolbar-bar .contextual-toolbar-tab {

Picked up css selectors.

Just to manually check best I could I did use phpstorm search

I did search for ' gin ' with the spaces as just searching for gin gave me 4700 hits lol.

Thank you @quietone for keeping pushing these forward.

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Needs review

Shouldn't we use the name that was decided in #3576646: Rename Gin-based admin theme? Default Admin vs. Admin...

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

That's going to trip me up because I've been saying Admin theme this entire time. Looks like @quietone addressed the comment.

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Needs work

Sorry for issue status ping-pong but I went through the MR thoroughly this time.

quietone’s picture

quietone commented
Status: Needs work » Needs review
amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Changes look good to me.

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 92cd61b7b50 to main and 7c14c328470 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15312

  • amateescu committed 7c14c328 on 11.x 
    task: #3582610 Rename gin in comments

By: quietone
By: smustgrave
By:...

  • amateescu committed 92cd61b7 on main 
    task: #3582610 Rename gin in comments

By: quietone
By: smustgrave
By:...
poker10’s picture

poker10 commented

Seems like some gin_ hook mentions in comments were missed. I created another issue: #3584302: Update referenced Gin hooks in comments

quietone’s picture

quietone commented
Issue summary: View changes

Yes, they were specifically not done here. I never did get around to updating the issue summary, which I have done now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.